Skip to contentSkip to conversation

ALSA: hda - Reduce the suspend time consumption for ALC256

PATCH New Takashi Iwai 1 participant 1 message Jan 19, 2018 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ALSA: hda - Reduce the suspend time consumption for ALC256

ALC256 has its own quirk to override the shutup call, and it contains the COEF update for pulling down the headset jack control. Currently, the COEF update is called after clearing the headphone pin, and this seems triggering a stall of the codec communication, and results in a long delay over a second at suspend.

A quick resolution is to swap the calls: at first with the COEF update, then clear the headphone pin.

Fixes 4a219ef8f370 ("ALSA: hda/realtek - Add ALC256 HP depop function")

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=198503

---
 sound/pci/hda/patch_realtek.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
sound/pci/hda/patch_realtek.c +4 -2
index 0004e282a837..23475888192b 100644
@@ -3154,11 +3154,13 @@ static void alc256_shutup(struct hda_codec *codec)
 	if (hp_pin_sense)
 		msleep(85);
 
+	/* 3k pull low control for Headset jack. */
+	/* NOTE: call this before clearing the pin, otherwise codec stalls */
+	alc_update_coef_idx(codec, 0x46, 0, 3 << 12);
+
 	snd_hda_codec_write(codec, hp_pin, 0,
 			    AC_VERB_SET_PIN_WIDGET_CONTROL, 0x0);
 
-	alc_update_coef_idx(codec, 0x46, 0, 3 << 12); /* 3k pull low control for Headset jack. */
-
 	if (hp_pin_sense)
 		msleep(100);
 
Signature · 1 line
2.15.1