ASoC: codecs: dmic: Fix check of return value from read of 'num-channels'
PATCH 1/1 ASoC: codecs: dmic: Fix check of return value from read of 'num-channels'
Commit 7fb59e940f62 ("ASoC: codecs: dmic: Make number of channels
configurable") introduces an optional property to the device tree
to specify the number of DMIC channels. dmic_codec_probe() uses of_property_read_u32() to read the DT value, and expects a return value of -ENOENT when the property does not exist. This expectation is incorrect, the actual value returned in this case is -EINVAL (see of_find_property_value_of_size(), which is called under the hood). Check for -EINVAL instead.
--- sound/soc/codecs/dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/dmic.c +1 -1
@@ -113,7 +113,7 @@ static int dmic_dev_probe(struct platform_device *pdev)if (pdev->dev.of_node) { err =of_property_read_u32 (pdev->dev.of_node,"num-channels" , &chans); -if (err && (err != -ENOENT )) +if (err && (err != -EINVAL ))return err;if (!err) {
Signature · 1 line
2.16.0.rc1.238.g530d649a79-goog
Mark Brown
maintainerQuoted 3 lines · Matthias Kaehlcke
Commit
7fb59e940f62("ASoC: codecs: dmic: Make number of channels
configurable") introduces an optional property to the device tree
to specify the number of DMIC channels.dmic_codec_probe()uses
Please submit patches using subject lines reflecting the style for the subsystem. This makes it easier for people to identify relevant patches. Look at what existing commits in the area you're changing are doing and make sure your subject lines visually resemble what they're doing.
Mark Brown
maintainerApplied "ASoC: dmic: Fix check of return value from read of 'num-channels'" to the asoc tree
In reply to Matthias KaehlckeThe patch
ASoC: dmic: Fix check of return value from read of 'num-channels'
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
Quoted 1 line
From
35b84bf0614a7da98bfbbac70ed3d01c3b5b6c58Mon Sep 17 00:00:00 2001
From: Matthias Kaehlcke <[email protected]>
Date: Fri, 19 Jan 2018 15:36:50 -0800
Subject: [PATCH] ASoC: dmic: Fix check of return value from read of
'num-channels'
Commit 7fb59e940f62 ("ASoC: codecs: dmic: Make number of channels
configurable") introduces an optional property to the device tree
to specify the number of DMIC channels. dmic_codec_probe() uses of_property_read_u32() to read the DT value, and expects a return value of -ENOENT when the property does not exist. This expectation is incorrect, the actual value returned in this case is -EINVAL (see of_find_property_value_of_size(), which is called under the hood). Check for -EINVAL instead.
--- sound/soc/codecs/dmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/dmic.c +1 -1
@@ -113,7 +113,7 @@ static int dmic_dev_probe(struct platform_device *pdev)if (pdev->dev.of_node) { err =of_property_read_u32 (pdev->dev.of_node,"num-channels" , &chans); -if (err && (err != -ENOENT )) +if (err && (err != -EINVAL ))return err;if (!err) {
Signature · 1 line
2.15.1