power: supply: da9030_battery: fix boolean value assignment in da9030_set_charge

PATCH New Gustavo A. R. Silva 1 participant 1 message Jan 20, 2018 Power supply

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-01-20 03:52 UTC #0 lore raw

PATCH 1/1 power: supply: da9030_battery: fix boolean value assignment in da9030_set_charge

Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Fixes 342d765e011f ("power_supply: Add Dialog DA9030 battery charger driver")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/power/supply/da9030_battery.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/power/supply/da9030_battery.c +2 -2

index 5ca0f4d..2cc05bc 100644
@@ -238,10 +238,10 @@ static void da9030_set_charge(struct da9030_charger *charger, int on)
 		val = DA9030_CHRG_CHARGER_ENABLE;
 		val |= (charger->charge_milliamp / 100) << 3;
 		val |= (charger->charge_millivolt - 4000) / 50;
-		charger->is_on = 1;
+		charger->is_on = true;
 	} else {
 		val = 0;
-		charger->is_on = 0;
+		charger->is_on = false;
 	}
 
 	da903x_write(charger->master, DA9030_CHARGE_CONTROL, val);

Signature · 1 line

2.7.4