Skip to contentSkip to conversation

usb: xhci: Fix bool initialization in xhci_bulk_tx

PATCH New Gustavo A. R. Silva 3 participants 3 messages Jan 20, 2018 – Jan 22, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: xhci: Fix bool initialization in xhci_bulk_tx

Bool initializations should use true and false.

This issue was detected with the help of Coccinelle.

---
 drivers/usb/host/xhci-ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/xhci-ring.c +1 -1
index 579e670..7599c91 100644
@@ -557,7 +557,7 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
 {
 	int num_trbs = 0;
 	struct xhci_generic_trb *start_trb;
-	bool first_trb = 0;
+	bool first_trb = false;
 	int start_cycle;
 	u32 field = 0;
 	u32 length_field = 0;
Signature · 1 line
2.7.4
Applied
#1 lore raw

PATCH 1/1 usb: xhci: Fix bool initialization in xhci_bulk_tx

Quoted 7 lines · Gustavo A. R. Silva

Bool initializations should use true and false.

This issue was detected with the help of Coccinelle.

Applied, thanks

Quoted 18 lines
---
 drivers/usb/host/xhci-ring.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/host/xhci-ring.c +1 -1
index 579e670..7599c91 100644
@@ -557,7 +557,7 @@ int xhci_bulk_tx(struct usb_device *udev, unsigned long pipe,
 {
 	int num_trbs = 0;
 	struct xhci_generic_trb *start_trb;
-	bool first_trb = 0;
+	bool first_trb = false;
 	int start_cycle;
 	u32 field = 0;
 	u32 length_field = 0;
Signature · 2 lines
Best regards,
Marek Vasut
#2 lore raw

PATCH 1/1 usb: xhci: Fix bool initialization in xhci_bulk_tx

Quoting Marek Vasut <[email protected]>:

Quoted 11 lines · Gustavo A. R. Silva
Quoted 7 lines

Bool initializations should use true and false.

This issue was detected with the help of Coccinelle.

Applied, thanks

Thank you, Marek. This is my very first contribution to the Das U-Boot project. :)
--
Gustavo