Skip to contentSkip to conversation

tools/mrvl_uart.sh: Fix minicom baudrate

PATCH New Andreas Färber 3 participants 4 messages Jan 20, 2018 – Jan 29, 2018

lore
Share & tools
lore

Andreas Färber

author
#0 lore raw

PATCH 1/1 tools/mrvl_uart.sh: Fix minicom baudrate

minicom doesn't inherit the baudrate from stty but uses its own defaults, such as for example 57600, whereas we expect 115200 here. Explicitly tell minicom which baudrate to use.

Fixes eee4835d22 ("tools: Add Marvell recovery image download script")
Cc Konstantin Porotchkin <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Igal Liberman <[email protected]>
Signed-off-by Andreas Färber <[email protected]>
---
 tools/mrvl_uart.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/mrvl_uart.sh +1 -1
index 6b04d7ae2c..500fa117eb 100755
@@ -115,5 +115,5 @@ sx -vv $file > $port < $port
 stty -F $port raw ignbrk time 5 $default_baudrate
 
 # Optional - fire up Minicom
-minicom -D $port
+minicom -D $port -b $default_baudrate
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 tools/mrvl_uart.sh: Fix minicom baudrate

Quoted 34 lines

-----Original Message-----
From: Andreas Färber [mailto:afaerber at suse.de]
Sent: Saturday, January 20, 2018 14:07
To: u-boot at lists.denx.de
Cc: Andreas Färber; Kostya Porotchkin; Stefan Roese; Igal Liberman
Subject: [PATCH] tools/mrvl_uart.sh: Fix minicom baudrate

minicom doesn't inherit the baudrate from stty but uses its own defaults, such as for example 57600, whereas we expect 115200 here. Explicitly tell minicom which baudrate to use.

Fixes eee4835d22 ("tools: Add Marvell recovery image download script")
Cc Konstantin Porotchkin <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Igal Liberman <[email protected]>
Signed-off-by Andreas Färber <[email protected]>
---
 tools/mrvl_uart.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/mrvl_uart.sh index renamed from tools/mrvl_uart.sh +0 -0

6b04d7ae2c..500fa117eb 100755

tools/mrvl_uart.sh +0 -0
@@ -115,5 +115,5 @@ sx -vv $file > $port < $port  stty -F $port raw

ignbrk time 5 $default_baudrate

# Optional - fire up Minicom

tools/mrvl_uart.sh +1 -2
-minicom -D $port
+minicom -D $port -b $default_baudrate
 
--
Quoted 1 line

2.13.6

Reviewed-by Konstantin Porotchkin <[email protected]>
#2 lore raw

PATCH 1/1 tools/mrvl_uart.sh: Fix minicom baudrate

In reply to Andreas Färber
Quoted 19 lines · Andreas Färber

minicom doesn't inherit the baudrate from stty but uses its own defaults, such as for example 57600, whereas we expect 115200 here. Explicitly tell minicom which baudrate to use.

Fixes eee4835d22 ("tools: Add Marvell recovery image download script")
Cc Konstantin Porotchkin <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Igal Liberman <[email protected]>
Signed-off-by Andreas Färber <[email protected]>
---
  tools/mrvl_uart.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/mrvl_uart.sh +0 -0
index 6b04d7ae2c..500fa117eb 100755

tools/mrvl_uart.sh sx -vv $file > $port < $port · line 119

Quoted 6 lines
tools/mrvl_uart.sh +1 -1
@@ -115,5 +115,5 @@ sx -vv $file > $port < $port
  stty -F $port raw ignbrk time 5 $default_baudrate
 
  # Optional - fire up Minicom
-minicom -D $port
+minicom -D $port -b $default_baudrate
Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

#3 lore raw

PATCH 1/1 tools/mrvl_uart.sh: Fix minicom baudrate

In reply to Andreas Färber
Quoted 19 lines · Andreas Färber

minicom doesn't inherit the baudrate from stty but uses its own defaults, such as for example 57600, whereas we expect 115200 here. Explicitly tell minicom which baudrate to use.

Fixes eee4835d22 ("tools: Add Marvell recovery image download script")
Cc Konstantin Porotchkin <[email protected]>
Cc Stefan Roese <[email protected]>
Cc Igal Liberman <[email protected]>
Signed-off-by Andreas Färber <[email protected]>
---
  tools/mrvl_uart.sh | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tools/mrvl_uart.sh +0 -0
index 6b04d7ae2c..500fa117eb 100755

tools/mrvl_uart.sh sx -vv $file > $port < $port · line 119

Quoted 6 lines
tools/mrvl_uart.sh +1 -1
@@ -115,5 +115,5 @@ sx -vv $file > $port < $port
  stty -F $port raw ignbrk time 5 $default_baudrate
 
  # Optional - fire up Minicom
-minicom -D $port
+minicom -D $port -b $default_baudrate

Applied to u-boot-marvell/master.

Thanks,
Stefan