staging: lustre: libcfs: Prevent harmless read underflow

PATCH New Dan Carpenter 1 participant 1 message Jan 22, 2018

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2018-01-22 10:26 UTC #0 lore raw

PATCH 1/1 staging: lustre: libcfs: Prevent harmless read underflow

Because this is a post-op instead of a pre-op, then it means we check if knl_buffer[-1] is a space. It doesn't really hurt anything, but it causes a static checker warning so let's fix it.

Fixes d7e09d0397e8 ("staging: add Lustre file system client support")

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/lustre/lnet/libcfs/tracefile.c +1 -1

index da2844f37edf..57913aae1d88 100644
@@ -785,7 +785,7 @@ int cfs_trace_copyin_string(char *knl_buffer, int knl_buffer_nob,
 		return -EFAULT;
 
 	nob = strnlen(knl_buffer, usr_buffer_nob);
-	while (nob-- >= 0)		      /* strip trailing whitespace */
+	while (--nob >= 0)		      /* strip trailing whitespace */
 		if (!isspace(knl_buffer[nob]))
 			break;