Skip to contentSkip to conversation

Introduce s390_sthyi system call decoder

PATCH Eugene Syromiatnikov 1 participant 1 message Jan 22, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20180122131643.GB4806@osiris

#1 lore raw
Quoted 19 lines · Heiko Carstens
Quoted 7 lines · Eugene Syromyatnikov
(quoted diff) +7 -0
+static void
+print_sthyi_hypervisor(struct tcb *tcp, struct sthyi_hypervisor *hdr,
+		       uint16_t size, int num, bool mt)
+{
+	CHECK_SIZE(hdr, size, "hypervisor %d structure", num);
+
+	tprintf("/* hypervisor %d */ ", num);

Review

Quoted 10 lines
(quoted diff) +10 -0
+	PRINT_FIELD_0X("{", *hdr, infyflg1);
+	if (!abbrev(tcp) && hdr->infyflg1)
+		tprintf_comment("%s%s%s%s%#.0x%s",
+			hdr->infyflg1 & 0x80 ?
+				"0x80 - guest CPU usage had limiting is using "
+				"the consumption method" : "",
+			(hdr->infyflg1 & 0x80) && (hdr->infyflg1 & 0x40) ?
+				", " : "",
+			hdr->infyflg1 & 0x40 ?
+				"0x40 -  LIMITHARD caps use prorated core time "
                                       ^^
Quoted 2 lines

Here you have two whitespace characters (instead of one) which cause the s390_sthyi-v test to fail.

Uhh, sorry, I've overlooked it (on the other side, that's what are tests for). I'll resend the patch. Thank you for the report!