drm/edid: use false for boolean value
Subsystems (2)
PATCH 1/1 drm/edid: use false for boolean value
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
--- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/drm_edid.c +1 -1
@@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)drm_mode_probed_add (closure->connector, newmode); closure->modes++; - closure->preferred =0 ; + closure->preferred = false; } }
Signature · 1 line
2.7.4
Quoted 5 lines · Gustavo A. R. Silva
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks for your patch.
Quoted 9 lines
--- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0
drivers/gpu/drm/drm_edid.c do_detailed_mode(struct detailed_timing *timing, void *c) · line 2770
Quoted 5 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)drm_mode_probed_add (closure->connector, newmode); closure->modes++; - closure->preferred =0 ; + closure->preferred = false;
There's also
.preferred = 1,
in add_detailed_modes. Please fix that one up too for consistency, then I'll merge your patch.
Cheers, Daniel
Quoted 10 lines
drivers/gpu/drm/drm_edid.c +0
-0} }Signature · 6 lines
2.7.4 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Daniel,
Quoting Daniel Vetter <[email protected]>:
Quoted 27 lines · Gustavo A. R. Silva
Quoted 5 lines
Assign true or false to boolean variables instead of an integer value.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>Thanks for your patch.
Quoted 9 lines
--- drivers/gpu/drm/drm_edid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/drm_edid.c +0
-0drivers/gpu/drm/drm_edid.c do_detailed_mode(struct detailed_timing · line 2771
Quoted 6 lines
drivers/gpu/drm/drm_edid.c +1
-1@@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c)drm_mode_probed_add (closure->connector, newmode); closure->modes++; - closure->preferred =0 ; + closure->preferred = false;There's also
Quoted 5 lines
.preferred = 1,in
add_detailed_modes. Please fix that one up too for consistency, then I'll merge your patch.
Sure. I'll send a new patch shortly.
I also need to update the Coccinelle script to catch those cases.
Thanks for the feedback.
--
Gustavo