ASoC: rt5514-spi: Check the validity of drvdata pointer on resume
Subsystems (3)
PATCH RESEND 1/1 ASoC: rt5514-spi: Check the validity of drvdata pointer on resume
The rt5514-spi driver seem to assume the validity of the drvdata pointer on resume, which it may not be populated, leading to a not-so-nice crash.
This stems from the fact that rt5514_spi_pcm_probe() is never called on my system (a kevin Chromebook). No idea why, but if it can happen, it is worth fixing.
Fixes e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule data copy in resume function")
Signed-off-by Marc Zyngier <[email protected]>
--- sound/soc/codecs/rt5514-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/rt5514-spi.c +1 -1
@@ -482,7 +482,7 @@ static int __maybe_unused rt5514_resume(struct device *dev)if (device_may_wakeup (dev))disable_irq_wake (irq); -if (rt5514_dsp->substream) { +if (rt5514_dsp && rt5514_dsp->substream) {rt5514_spi_burst_read (RT5514_IRQ_CTRL , (u8 *)&buf,sizeof (buf));if (buf[0 ] &RT5514_IRQ_STATUS_BIT )rt5514_schedule_copy (rt5514_dsp);
Signature · 1 line
2.14.2