Skip to contentSkip to conversation

lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN

PATCH In review Ivan Delalande 2 participants 2 messages Jan 25, 2018 Char and misc drivers

lore
Share & tools
lore

Ivan Delalande

author
#0 lore raw

PATCH 1/1 lkdtm: fix handle_irq_event symbol for INT_HW_IRQ_EN

Function handle_IRQ_event was retired in v2.6.39 and replaced with handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has been broken for a while.

Fixes 33b054b867b8 ("genirq: Remove handle_IRQ_event")
Signed-off-by Travis Brown <[email protected]>
Signed-off-by Ivan Delalande <[email protected]>
Acked-by Kees Cook <[email protected]>
---
 drivers/misc/lkdtm_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/lkdtm_core.c +1 -1
index ba92291508dc..4942da93d066 100644
@@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
 	CRASHPOINT("DIRECT",		 NULL),
 #ifdef CONFIG_KPROBES
 	CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
-	CRASHPOINT("INT_HW_IRQ_EN",	 "handle_IRQ_event"),
+	CRASHPOINT("INT_HW_IRQ_EN",	 "handle_irq_event"),
 	CRASHPOINT("INT_TASKLET_ENTRY",	 "tasklet_action"),
 	CRASHPOINT("FS_DEVRW",		 "ll_rw_block"),
 	CRASHPOINT("MEM_SWAPOUT",	 "shrink_inactive_list"),
Signature · 1 line
2.16.1
Acked-by on v1 1/1
#1 lore raw
Quoted 3 lines · Ivan Delalande

Function handle_IRQ_event was retired in v2.6.39 and replaced with handle_irq_event but nobody changed it in lkdtm so INT_HW_IRQ_EN has been broken for a while.

Excellent, thanks for the fix!

Acked-by Kees Cook <[email protected]>

Greg, I don't have any other exclusive lkdtm updates, so please feel free to apply this to misc-next.

Thanks!

-Kees

Quoted 23 lines
Fixes 33b054b867b8 ("genirq: Remove handle_IRQ_event")
Signed-off-by Travis Brown <[email protected]>
Signed-off-by Ivan Delalande <[email protected]>
---
 drivers/misc/lkdtm_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/lkdtm_core.c +1 -2
index ba92291508dc..4942da93d066 100644
@@ -96,7 +96,7 @@ static struct crashpoint crashpoints[] = {
        CRASHPOINT("DIRECT",             NULL),
 #ifdef CONFIG_KPROBES
        CRASHPOINT("INT_HARDWARE_ENTRY", "do_IRQ"),
-       CRASHPOINT("INT_HW_IRQ_EN",      "handle_IRQ_event"),
+       CRASHPOINT("INT_HW_IRQ_EN",      "handle_irq_event"),
        CRASHPOINT("INT_TASKLET_ENTRY",  "tasklet_action"),
        CRASHPOINT("FS_DEVRW",           "ll_rw_block"),
        CRASHPOINT("MEM_SWAPOUT",        "shrink_inactive_list"),
--

2.16.1

Signature · 2 lines
Kees Cook
Pixel Security