dm: serial: Initialize serial console only when it wasn't already configured
PATCH 1/1 dm: serial: Initialize serial console only when it wasn't already configured
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g. board_init()) when the "initr_serial" is called.
As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiB
jSS('HH��SL_SDHC: 04 rev 0x0
This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
This patch is a follow up of following discussions:
http://patchwork.ozlabs.org/patch/820824/
http://patchwork.ozlabs.org/patch/830957/
---
drivers/serial/serial-uclass.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/serial/serial-uclass.c +3 -0
@@ -129,6 +129,9 @@ static void serial_find_console_or_panic(void)/* Called prior to relocation */ int serial_init (void ) { +if (gd->flags &GD_FLG_SERIAL_READY ) +return 0 ; +serial_find_console_or_panic (); gd->flags |=GD_FLG_SERIAL_READY ;
Signature · 1 line
2.11.0
PATCH 1/1 dm: serial: Initialize serial console only when it wasn't already configured
Quoted 18 lines · Lukasz Majewski
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g.
board_init()) when the "initr_serial" is called.As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiBjSS('HH��SL_SDHC: 04 rev
0x0This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
Quoted 6 lines
This patch is a follow up of following discussions:
http://patchwork.ozlabs.org/patch/820824/
http://patchwork.ozlabs.org/patch/830957/Signed-off-by Lukasz Majewski <[email protected]>
Thanks,
Stefan
PATCH 1/1 dm: serial: Initialize serial console only when it wasn't already configured
In reply to Lukasz MajewskiDear All,
Quoted 19 lines
It may happen that the MXC serial IP block is performing some ongoing transmission (started at e.g.
board_init()) when the "initr_serial" is called.As a result the serial port IP block is reset, so transmitted data is corrupted:
I2C: ready DRAM: 1 GiBjSS('HH��SL_SDHC: 04 rev
0x0This patch prevents from this situation, by avoiding re-initialization of serial IP block (and execution of the same code twice).
I2C: ready DRAM: 1 GiB ID: unit type 0x4 rev 0x0
Quoted 6 lines
This patch is a follow up of following discussions:
http://patchwork.ozlabs.org/patch/820824/
http://patchwork.ozlabs.org/patch/830957/Signed-off-by Lukasz Majewski <[email protected]>
After some excessive testing it turned out that this patch is not behaving as expected.
Please drop it. I will find another, better solution for this issue.
Sorry for trouble.
Quoted 11 lines
---
drivers/serial/serial-uclass.c | 3 +++ 1 file changed, 3 insertions(+)(quoted diff) +0
-0
b/drivers/serial/serial-uclass.cindex2e5116f7ce..c345578b36100644
drivers/serial/serial-uclass.c static void serial_find_console_or_panic(void) · line 137
Quoted 9 lines
drivers/serial/serial-uclass.c +3
-0@@ -129,6 +129,9 @@ static void serial_find_console_or_panic(void)/* Called prior to relocation */ int serial_init (void ) { +if (gd->flags &GD_FLG_SERIAL_READY ) +return 0 ; +serial_find_console_or_panic (); gd->flags |=GD_FLG_SERIAL_READY ;
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180202/2bda7d32/attachment.sig>