m68k/mac: Enable PDMA support for PowerBook 190
Subsystems (2)
PATCH 1/1 m68k/mac: Enable PDMA support for PowerBook 190
Stan's tests showed that PDMA improves sequential read performance by a factor of 5 on a PowerBook 190. Last time I tried this on a PowerBook 520 it didn't work, so let's not enable it there until it can be tested with the present mac_scsi driver.
--- arch/m68k/mac/config.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
arch/m68k/mac/config.c +2 -4
@@ -713,7 +713,7 @@ static struct mac_model mac_data_table[] = { .name = "PowerBook 190", .adb_type = MAC_ADB_PB2, .via_type = MAC_VIA_QUADRA, - .scsi_type = MAC_SCSI_LATE, + .scsi_type = MAC_SCSI_OLD, .ide_type = MAC_IDE_BABOON, .scc_type = MAC_SCC_QUADRA, .nubus_type = MAC_NUBUS,
@@ -1077,9 +1077,7 @@ int __init mac_platform_init(void) mac_scsi_old_rsrc, ARRAY_SIZE(mac_scsi_old_rsrc));break ;case MAC_SCSI_LATE : -/* PDMA logic in 68040 PowerBooks is somehow different to -* '030 models. It's probably more like Quadras (see mac_esp). -*/ +/* XXX PDMA support for PowerBook 500 series needs testing */ platform_device_register_simple ("mac_scsi" ,0 , mac_scsi_late_rsrc,ARRAY_SIZE (mac_scsi_late_rsrc));break ;
Signature · 1 line
2.13.6
Geert Uytterhoeven
maintainerHi Finn,
Quoted 7 lines · Finn Thain
Stan's tests showed that PDMA improves sequential read performance by a factor of 5 on a PowerBook 190. Last time I tried this on a PowerBook 520 it didn't work, so let's not enable it there until it can be tested with the present
mac_scsidriver.Tested-by Stan Johnson <[email protected]>Signed-off-by Finn Thain <[email protected]>
Thanks for your patch!
Anyone with a PB520 who can check if it works now with scsi_type = MAC_SCSI_OLD?
Quoted 18 lines
--- arch/m68k/mac/config.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)arch/m68k/mac/config.c +1
-1@@ -713,7 +713,7 @@ static struct mac_model mac_data_table[] = { .name = "PowerBook 190", .adb_type = MAC_ADB_PB2, .via_type = MAC_VIA_QUADRA, - .scsi_type = MAC_SCSI_LATE, + .scsi_type = MAC_SCSI_OLD, .ide_type = MAC_IDE_BABOON, .scc_type = MAC_SCC_QUADRA, .nubus_type = MAC_NUBUS,
arch/m68k/mac/config.c int __init mac_platform_init(void) · line 1083
Quoted 10 lines
arch/m68k/mac/config.c +1
-3@@ -1077,9 +1077,7 @@ int __init mac_platform_init(void) mac_scsi_old_rsrc, ARRAY_SIZE(mac_scsi_old_rsrc));break ;case MAC_SCSI_LATE : -/* PDMA logic in 68040 PowerBooks is somehow different to -* '030 models. It's probably more like Quadras (see mac_esp). -*/ +/* XXX PDMA support for PowerBook 500 series needs testing */ platform_device_register_simple ("mac_scsi" ,0 , mac_scsi_late_rsrc,ARRAY_SIZE (mac_scsi_late_rsrc));break ;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 4 lines · Geert Uytterhoeven
Anyone with a PB520 who can check if it works now with
scsi_type=MAC_SCSI_OLD?
The PB520 and PB540 have a flawed early-revision 68LC040 processor* which makes it unlikely that these machines are running Linux (or NetBSD). A few have had backyard CPU upgrades, like my own. I'll test MAC_SCSI_OLD at some point, but I don't know when that will be.
The PB550 doesn't have the 68LC040 problem but it was only available in Japan. These machines may have Linux or NetBSD on them, but they are rare and their owners may not be found on these lists.
Quoted 4 lines · Geert Uytterhoeven
Anyone with a PB520 who can check if it works now with
scsi_type=MAC_SCSI_OLD?
The PB520 and PB540 have a flawed early-revision 68LC040 processor* which makes it unlikely that these machines are running Linux (or NetBSD). A few have had backyard CPU upgrades, like my own. I'll test MAC_SCSI_OLD at some point, but I don't know when that will be.
The PB550 doesn't have the 68LC040 problem but it was only available in Japan. These machines may have Linux or NetBSD on them, but they are rare and their owners may not be found on these lists.
Quoted 7 lines · Finn Thain
Stan's tests showed that PDMA improves sequential read performance by a factor of 5 on a PowerBook 190. Last time I tried this on a PowerBook 520 it didn't work, so let's not enable it there until it can be tested with the present
mac_scsidriver.Tested-by Stan Johnson <[email protected]>Signed-off-by Finn Thain <[email protected]>
Thanks, applied and queue for v4.17.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds