checkpatch changes for 4.16
Hi Joe,
Can I please bother you with a maintainer question. I know everyone is super busy right now, I'm asking for a smidgen of your time instead of doing it wrong and taking up some of Linus' time since it's merge window and all that.
I have the checkpatch set queued ready to do a GIT PULL to Linus. My concern is that the subject line may not be unique if checkpatch changes are coming in from various trees this merge window. I have tagged the pull request with
checkpatch-4.16-rc1
with the subject line
[GIT PULL] checkpatch changes for 4.16-rc1
If there are no other changes to checkpatch going in this merge window then this issue dissolves. If there are, should I add something to the subject line to ensure it is unique?
Thanks and sorry for targeting you with this question, I'm sure you have better things to do also.
Tobin
Quoted 11 lines · Tobin C. Harding
Hi Joe,
Can I please bother you with a maintainer question. I know everyone is super busy right now, I'm asking for a smidgen of your time instead of doing it wrong and taking up some of Linus' time since it's merge window and all that.
I have the checkpatch set queued ready to do a GIT PULL to Linus. My concern is that the subject line may not be unique if checkpatch changes are coming in from various trees this merge window. I have tagged the pull request with
Personally, I think you could let Andrew Morton pick them up as very few patches for checkpatch go in any other way.
What patches are you submitting again?
Is it just
commit 7b1924a1d930 ("vsprintf: add printk specifier %px")
or is there something else?
Quoted 8 lines · Joe Perches
Quoted 7 lines · Tobin C. Harding
Hi Joe,
Can I please bother you with a maintainer question. I know everyone is super busy right now, I'm asking for a smidgen of your time instead of doing it wrong and taking up some of Linus' time since it's merge window and all that.
Quoted 7 lines
Quoted 4 lines
I have the checkpatch set queued ready to do a GIT PULL to Linus. My concern is that the subject line may not be unique if checkpatch changes are coming in from various trees this merge window. I have tagged the pull request with
Personally, I think you could let Andrew Morton pick them up as very few patches for checkpatch go in any other way.
ok no worries. I'll leave it until a few rc's are out then send to Andrew.
Quoted 7 lines
What patches are you submitting again?
Is it just
commit
7b1924a1d930("vsprintf: add printk specifier %px")or is there something else?
d94e97bc9ede checkpatch: add sub routine get_stat_real() d0e27c47f5b9 checkpatch: add sub routine get_stat_here() 986b3b5b7d7a checkpatch: warn for use of %px 26c1cf882d79 checkpatch: add check for tag Co-Developed-by
I thought it was odd when you said they could go in through _any_ tree. Not to worry, it's not urgent.
Thanks for the responce.
Tobin
Quoted 27 lines · Tobin C. Harding
Quoted 8 lines · Joe Perches
Quoted 7 lines · Tobin C. Harding
Hi Joe,
Can I please bother you with a maintainer question. I know everyone is super busy right now, I'm asking for a smidgen of your time instead of doing it wrong and taking up some of Linus' time since it's merge window and all that.
Quoted 7 lines
Quoted 4 lines
I have the checkpatch set queued ready to do a GIT PULL to Linus. My concern is that the subject line may not be unique if checkpatch changes are coming in from various trees this merge window. I have tagged the pull request with
Personally, I think you could let Andrew Morton pick them up as very few patches for checkpatch go in any other way.
ok no worries. I'll leave it until a few rc's are out then send to Andrew.
Quoted 7 lines
What patches are you submitting again?
Is it just
commit
7b1924a1d930("vsprintf: add printk specifier %px")or is there something else?
Quoted 7 lines
d94e97bc9edecheckpatch: add sub routineget_stat_real()d0e27c47f5b9checkpatch: add sub routineget_stat_here()986b3b5b7d7acheckpatch: warn for use of %px26c1cf882d79checkpatch: add check for tag Co-Developed-byI thought it was odd when you said they could go in through _any_ tree. Not to worry, it's not urgent.
Stuff that is going to be pulled should at least
marinate in -next for awhile first and not first
be presented as a pull request.
Quoted 33 lines · Joe Perches
Quoted 32 lines · Tobin C. Harding
Quoted 8 lines · Joe Perches
Quoted 7 lines · Tobin C. Harding
Hi Joe,
Can I please bother you with a maintainer question. I know everyone is super busy right now, I'm asking for a smidgen of your time instead of doing it wrong and taking up some of Linus' time since it's merge window and all that.
Quoted 7 lines
Quoted 4 lines
I have the checkpatch set queued ready to do a GIT PULL to Linus. My concern is that the subject line may not be unique if checkpatch changes are coming in from various trees this merge window. I have tagged the pull request with
Personally, I think you could let Andrew Morton pick them up as very few patches for checkpatch go in any other way.
ok no worries. I'll leave it until a few rc's are out then send to Andrew.
Quoted 7 lines
What patches are you submitting again?
Is it just
commit
7b1924a1d930("vsprintf: add printk specifier %px")or is there something else?
d94e97bc9edecheckpatch: add sub routineget_stat_real()d0e27c47f5b9checkpatch: add sub routineget_stat_here()986b3b5b7d7acheckpatch: warn for use of %px26c1cf882d79checkpatch: add check for tag Co-Developed-by
Quoted 6 lines
Quoted 2 lines
I thought it was odd when you said they could go in through _any_ tree. Not to worry, it's not urgent.
Stuff that is going to be pulled should at least
marinate in -next for awhile first and not first
be presented as a pull request.
Oh cheers, I forgot about that for leaking_addresses patches too :(
thanks,
Tobin.