IB/ipoib: Fix for potential no-carrier state
PATCH 1/1 IB/ipoib: Fix for potential no-carrier state
From: Alex Estrin <[email protected]>
On reboot SM can program port pkey table before ipoib registered its event handler, which could result in missing pkey event and leave root interface with initial pkey value from index 0.
Since OPA port starts with invalid pkey in index 0, root interface will fail to initialize and stay down with no-carrier flag.
For IB ipoib interface may end up with pkey different from value opensm put in pkey table idx 0, resulting in connectivity issues (different mcast groups, for example).
Close the window by calling event handler after registration to make sure ipoib pkey is in sync with port pkey table.
--- drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_main.c +3 -0
@@ -2306,6 +2306,9 @@ void ipoib_set_dev_features(struct ipoib_dev_priv *priv, struct ib_device *hca) priv->ca, ipoib_event);ib_register_event_handler (&priv->event_handler); +/* call event handler to ensure pkey in sync */ +queue_work (ipoib_workqueue, &priv->flush_heavy); + result =register_netdev (priv->dev);if (result) { pr_warn("%s: couldn't register ipoib port %d; error %d\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 20180201185533.9091.17941.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org
Quoted 16 lines · Dennis Dalessandro
From: Alex Estrin <[email protected]>
On reboot SM can program port pkey table before ipoib registered its event handler, which could result in missing pkey event and leave root interface with initial pkey value from index 0.
Since OPA port starts with invalid pkey in index 0, root interface will fail to initialize and stay down with no-carrier flag.
For IB ipoib interface may end up with pkey different from value opensm put in pkey table idx 0, resulting in connectivity issues (different mcast groups, for example).
Close the window by calling event handler after registration to make sure ipoib pkey is in sync with port pkey table.
Quoted 6 lines
Reviewed-by Mike Marciniszyn <[email protected]>Reviewed-by Ira Weiny <[email protected]>Signed-off-by Alex Estrin <[email protected]>Signed-off-by Dennis Dalessandro <[email protected]>drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
Seemed liked Doug was Ok with the explanation, so applied to for-next
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html