Skip to contentSkip to conversation

iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined

PATCH In review Andreas Klinger 2 participants 2 messages Feb 1, 2018 – Feb 4, 2018 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iio: srf08: fix link error "devm_iio_triggered_buffer_setup" undefined

Functions for triggered buffer support are needed by this module. If they are not defined accidentally by another driver, there's an error thrown out while linking.

Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.

---
 drivers/iio/proximity/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/proximity/Kconfig +2 -0
index fcb1c4ba5e41..f726f9427602 100644
@@ -68,6 +68,8 @@ config SX9500
 
 config SRF08
 	tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	depends on I2C
 	help
 	  Say Y here to build a driver for Devantech SRF02/SRF08/SRF10
Signature · 4 lines
2.1.4


-- 
maintainer
#1 lore raw
Quoted 7 lines · On Thu, 1 Feb 2018 21:49:24 +0100 Andreas Klinger <[email protected]> wrote:

Functions for triggered buffer support are needed by this module. If they are not defined accidentally by another driver, there's an error thrown out while linking.

Add a select of IIO_BUFFER and IIO_TRIGGERED_BUFFER in the Kconfig file.

Applied to the fixes-togreg-post-rc1 branch of iio.git with a fixes tag added. Please always track down the patch that introduced the problem and add a fixes tag. It makes it much easier for the stable trees to know when to apply the patch or not.

I put the patch that introduced the triggered support in the first place as that seemed likely to be the place that the issue was introduced.

Thanks,

Jonathan

Quoted 17 lines
---
 drivers/iio/proximity/Kconfig | 2 ++
 1 file changed, 2 insertions(+)
drivers/iio/proximity/Kconfig +2 -0
index fcb1c4ba5e41..f726f9427602 100644
@@ -68,6 +68,8 @@ config SX9500
 
 config SRF08
 	tristate "Devantech SRF02/SRF08/SRF10 ultrasonic ranger sensor"
+	select IIO_BUFFER
+	select IIO_TRIGGERED_BUFFER
 	depends on I2C
 	help
 	  Say Y here to build a driver for Devantech SRF02/SRF08/SRF10