Skip to contentSkip to conversation

net/ixgbe: fix busy wait in ixgbevf_check_link()

PATCH Applied Chas Williams 2 participants 3 messages Feb 1, 2018 – Apr 6, 2018 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/ixgbe: fix busy wait in ixgbevf_check_link()

From: "Charles (Chas) Williams" <[email protected]>

If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly.

Fixes dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -1
index 37eb668..f6fd1c9 100644
@@ -3861,7 +3861,7 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,
 	/* for SFP+ modules and DA cables on 82599 it can take up to 500usecs
 	 * before the link status is correct
 	 */
-	if (mac->type == ixgbe_mac_82599_vf) {
+	if (mac->type == ixgbe_mac_82599_vf && wait_to_complete) {
 		int i;
 
 		for (i = 0; i < 5; i++) {
Signature · 1 line
2.9.5
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Chas Williams
Sent: Friday, February 2, 2018 6:39 AM
To: [email protected]
Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()

From: "Charles (Chas) Williams" <[email protected]>

Quoted 8 lines

If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly.

Fixes dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")

BTW, the title should be corrected by following the format rule of patches on DPDK community. Basically it shouldn't mention the function name in the title.

Applied
#2 lore raw
Quoted 26 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Zhang, Helin
Sent: Friday, April 6, 2018 11:09 PM
To: Chas Williams; [email protected]
Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()

Quoted 15 lines

-----Original Message-----
From: dev [mailto:[email protected]] On Behalf Of Chas Williams
Sent: Friday, February 2, 2018 6:39 AM
To: [email protected]
Cc: Lu, Wenzhuo; Ananyev, Konstantin; Charles (Chas) Williams
Subject: [dpdk-dev] [PATCH] net/ixgbe: fix busy wait in ixgbevf_check_link()

From: "Charles (Chas) Williams" <[email protected]>

If we haven't set wait_to_complete, there is no need to busy wait until we have a link status. Applications, like bonding, use the wait_to_complete flag to indicate that they will be doing their own busy wait and will likely be polling again shortly.

Quoted 4 lines
Quoted 3 lines
Fixes dc66e5fd01b9 ("net/ixgbe: improve link state check on VF")

Applied to dpdk-next-net-intel, with title modifcations. Thanks!

/Helin

Quoted 3 lines

BTW, the title should be corrected by following the format rule of patches on DPDK community. Basically it shouldn't mention the function name in the title.