potentail staging cleanup accel:adis16203 inclinonmeter.
Jonathan Cameron
maintainerHere's a second driver reviewed...
Vast majority of comments are the same as for the adis16201 driver.
The only real addition here is the nasty second inclinometer channel. It's just using a different range, so if you take the first and after it is greater than 180 degrees you instead make it negative, then you have the second channel.
My gut instinct is to drop reporting that channel at all. It doesn't add anything and it makes the userspace view of this hardware more complex.
Please read the 16201 review as well and the same suggestions apply on 'claiming' the driver if you want to clean it up.
Either way, both drivers should be straight forward to get ready for a staging graduation.
There are lots more features we 'could' support but absense of full support is not a reason to keep them in staging.
Thanks,
Jonathan
Quoted 6 lines
/*
* ADIS16203 Programmable 360 Degrees Inclinometer *
* Copyright 2010 Analog Devices Inc.
*
* Licensed under the GPL-2 or later.
Might as well convert to SPDX format whilst we are working on the driver.
Quoted 10 lines
*/
#include <
linux/delay.h>
#include <linux/device.h>#include <
linux/iio/buffer.h>
#include <linux/iio/iio.h>
#include <linux/iio/imu/adis.h>
#include <linux/iio/sysfs.h>
Quoted 6 lines
#include <
linux/kernel.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/spi/spi.h>
#include <linux/sysfs.h>
Put these into conventional header ordering.
Alphabetical with iio headers grouped at the end.
Quoted 2 lines
#define
ADIS16203_STARTUP_DELAY220 /* ms */
Include _MS in the naming and drop the comment.
Quoted 2 lines
/* Flash memory write count */
There are a lot of fairly 'obvious' comments here.
Add _REG naming to keep things consistent.
(see adis16201 review)
Quoted 96 lines
#define
ADIS16203_FLASH_CNT0x00/* Output, power supply */
#defineADIS16203_SUPPLY_OUT0x02/* Output, auxiliary ADC input */
#defineADIS16203_AUX_ADC0x08/* Output, temperature */
#defineADIS16203_TEMP_OUT0x0A/* Output, x-axis inclination */
#defineADIS16203_XINCL_OUT0x0C/* Output, y-axis inclination */
#defineADIS16203_YINCL_OUT0x0E/* Incline null calibration */
#defineADIS16203_INCL_NULL0x18/* Alarm 1 amplitude threshold */
#defineADIS16203_ALM_MAG10x20/* Alarm 2 amplitude threshold */
#defineADIS16203_ALM_MAG20x22/* Alarm 1, sample period */
#defineADIS16203_ALM_SMPL10x24/* Alarm 2, sample period */
#defineADIS16203_ALM_SMPL20x26/* Alarm control */
#defineADIS16203_ALM_CTRL0x28/* Auxiliary DAC data */
#defineADIS16203_AUX_DAC0x30/* General-purpose digital input/output control */
#defineADIS16203_GPIO_CTRL0x32/* Miscellaneous control */
#defineADIS16203_MSC_CTRL0x34/* Internal sample period (rate) control */
#defineADIS16203_SMPL_PRD0x36/* Operation, filter configuration */
#defineADIS16203_AVG_CNT0x38/* Operation, sleep mode control */
#defineADIS16203_SLP_CNT0x3A/* Diagnostics, system status register */
#defineADIS16203_DIAG_STAT0x3C/* Operation, system command register */
#defineADIS16203_GLOB_CMD0x3E/*
MSC_CTRL*//* Self-test at power-on: 1 = disabled, 0 = enabled */
#defineADIS16203_MSC_CTRL_PWRUP_SELF_TESTBIT(10)/* Reverses rotation of both inclination outputs */
#defineADIS16203_MSC_CTRL_REVERSE_ROT_ENBIT(9)/* Self-test enable */
#defineADIS16203_MSC_CTRL_SELF_TEST_ENBIT(8)/* Data-ready enable: 1 = enabled, 0 = disabled */
#defineADIS16203_MSC_CTRL_DATA_RDY_ENBIT(2)/* Data-ready polarity: 1 = active high, 0 = active low */
#defineADIS16203_MSC_CTRL_ACTIVE_HIGHBIT(1)/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
#defineADIS16203_MSC_CTRL_DATA_RDY_DIO1BIT(0)/*
DIAG_STAT*//* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
#defineADIS16203_DIAG_STAT_ALARM2BIT(9)/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
#defineADIS16203_DIAG_STAT_ALARM1BIT(8)/* Self-test diagnostic error flag */
#defineADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT5/* SPI communications failure */
#defineADIS16203_DIAG_STAT_SPI_FAIL_BIT3/* Flash update failure */
#defineADIS16203_DIAG_STAT_FLASH_UPT_BIT2
Quoted 7 lines
/* Power supply above 3.625 V */
#defineADIS16203_DIAG_STAT_POWER_HIGH_BIT1/* Power supply below 3.15 V */
#defineADIS16203_DIAG_STAT_POWER_LOW_BIT0/*
GLOB_CMD*/
See the adis16201 review for suggestions on how
to clean this up and drop unnecessary comemnts.
Quoted 26 lines
#define ADIS16203_GLOB_CMD_SW_RESET BIT(7) #define ADIS16203_GLOB_CMD_CLEAR_STAT BIT(4) #define ADIS16203_GLOB_CMD_FACTORY_CAL BIT(1)#define
ADIS16203_ERROR_ACTIVEBIT(14)enum adis16203_scan { ADIS16203_SCAN_INCLI_X, ADIS16203_SCAN_INCLI_Y, ADIS16203_SCAN_SUPPLY, ADIS16203_SCAN_AUX_ADC, ADIS16203_SCAN_TEMP, };#define
DRIVER_NAME"adis16203"static const u8 adis16203_addresses[] = { [ADIS16203_SCAN_INCLI_X] = ADIS16203_INCL_NULL, };static int adis16203_write_raw(struct
iio_dev*indio_dev,
structiio_chan_specconst *chan, int val,
int val2,
long mask)
Quoted 4 lines
{
struct adis *st = iio_priv(indio_dev);
/* currently only one writable parameter which keeps this simple */
u8 addr = adis16203_addresses[chan->scan_index];However it needs error checking as nothing stops us trying to write to other parameters from userspace. So check it's what we expect.
Also that mask should be generated with GENMASK to make it more obvious what it covers.
Quoted 43 lines
return adis_write_reg_16(st, addr, val & 0x3FFF); }static int adis16203_read_raw(struct
iio_dev*indio_dev,
structiio_chan_specconst *chan, int *val, int *val2, long mask){ struct adis *st = iio_priv(indio_dev); int ret; int bits; u8 addr; s16 val16; switch (mask) { case IIO_CHAN_INFO_RAW: return adis_single_conversion(indio_dev, chan, ADIS16203_ERROR_ACTIVE, val); case IIO_CHAN_INFO_SCALE: switch (chan->type) { case IIO_VOLTAGE: if (chan->channel == 0) { *val = 1; *val2 = 220000; /* 1.22 mV */ } else { *val = 0; *val2 = 610000; /* 0.61 mV */ } return IIO_VAL_INT_PLUS_MICRO; case IIO_TEMP: *val = -470; /* -0.47 C */ *val2 = 0; return IIO_VAL_INT_PLUS_MICRO; case IIO_INCLI: *val = 0; *val2 = 25000; /* 0.025 degree */ return IIO_VAL_INT_PLUS_MICRO; default: return -EINVAL; } case IIO_CHAN_INFO_OFFSET: *val = 25000 / -470 - 1278; /* 25 C = 1278 */
Quoted 8 lines
return IIO_VAL_INT; case IIO_CHAN_INFO_CALIBBIAS: bits = 14; addr = adis16203_addresses[chan->scan_index]; ret = adis_read_reg_16(st, addr, &val16); if (ret) return ret; val16 &= (1 << bits) - 1;
Given sign extension, the masking shouldn't make any difference.
Quoted 1 line
val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
Simple sign extension. Just use the standard functions. Also go directly to 32bits and put it in val.
Quoted 7 lines
*val = val16; return IIO_VAL_INT; default: return -EINVAL; } }
Quoted 6 lines
static const struct iio_chan_spec adis16203_channels[] = {
ADIS_SUPPLY_CHAN(ADIS16203_SUPPLY_OUT, ADIS16203_SCAN_SUPPLY, 0, 12),
ADIS_AUX_ADC_CHAN(ADIS16203_AUX_ADC, ADIS16203_SCAN_AUX_ADC, 0, 12),
ADIS_INCLI_CHAN(X, ADIS16203_XINCL_OUT, ADIS16203_SCAN_INCLI_X,
BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14),
/* Fixme: Not what it appears to be - see data sheet */This is just an offset version of the previous channel. I would drop it as it doesn't add anything significant that userspace can't trivially compute.
Quoted 38 lines
ADIS_INCLI_CHAN(Y, ADIS16203_YINCL_OUT, ADIS16203_SCAN_INCLI_Y, 0, 0, 14), ADIS_TEMP_CHAN(ADIS16203_TEMP_OUT, ADIS16203_SCAN_TEMP, 0, 12), IIO_CHAN_SOFT_TIMESTAMP(5), };static const struct iio_info adis16203_info = { .read_raw = adis16203_read_raw, .write_raw = adis16203_write_raw, .update_scan_mode = adis_update_scan_mode, };static const char * const adis16203_status_error_msgs[] = { [ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT] = "Self test failure", [ADIS16203_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure", [ADIS16203_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed", [ADIS16203_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V", [ADIS16203_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V", };static const struct adis_data adis16203_data = { .read_delay = 20, .msc_ctrl_reg = ADIS16203_MSC_CTRL, .glob_cmd_reg = ADIS16203_GLOB_CMD, .diag_stat_reg = ADIS16203_DIAG_STAT, .self_test_mask = ADIS16203_MSC_CTRL_SELF_TEST_EN, .self_test_no_autoclear = true, .startup_delay = ADIS16203_STARTUP_DELAY, .status_error_msgs = adis16203_status_error_msgs, .status_error_mask = BIT(ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT) | BIT(ADIS16203_DIAG_STAT_SPI_FAIL_BIT) | BIT(ADIS16203_DIAG_STAT_FLASH_UPT_BIT) | BIT(ADIS16203_DIAG_STAT_POWER_HIGH_BIT) | BIT(ADIS16203_DIAG_STAT_POWER_LOW_BIT), };
Quoted 7 lines
static int
adis16203_probe(struct spi_device *spi){ int ret; struct iio_dev *indio_dev; struct adis *st; /* setup the industrialio driver allocated elements */
Comment only tells us the obvious...
Quoted 5 lines
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; st = iio_priv(indio_dev); /* this is only used for removal purposes */
As before, doesn't add much as comments go.
Quoted 44 lines
spi_set_drvdata(spi, indio_dev); indio_dev->name = spi->dev.driver->name; indio_dev->dev.parent = &spi->dev; indio_dev->channels = adis16203_channels; indio_dev->num_channels = ARRAY_SIZE(adis16203_channels); indio_dev->info = &adis16203_info; indio_dev->modes = INDIO_DIRECT_MODE; ret = adis_init(st, indio_dev, spi, &adis16203_data); if (ret) return ret; ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); if (ret) return ret; /* Get the device into a sane initial state */ ret = adis_initial_startup(st); if (ret) goto error_cleanup_buffer_trigger; ret = iio_device_register(indio_dev); if (ret) goto error_cleanup_buffer_trigger; return 0;
error_cleanup_buffer_trigger:adis_cleanup_buffer_and_trigger(st, indio_dev); return ret; }static int
adis16203_remove(struct spi_device *spi){ struct iio_dev *indio_dev = spi_get_drvdata(spi); struct adis *st = iio_priv(indio_dev); iio_device_unregister(indio_dev); adis_cleanup_buffer_and_trigger(st, indio_dev); return 0; }
Quoted 8 lines
static struct spi_driver adis16203_driver = { .driver = { .name = "adis16203", }, .probe = adis16203_probe, .remove = adis16203_remove, };
module_spi_driver(adis16203_driver);
Device tree binding etc should probably be added + match tables so that this is useable on modern boards and probes automatically etc.
Quoted 5 lines
MODULE_AUTHOR("Barry Song <[email protected]>");MODULE_DESCRIPTION("Analog Devices ADIS16203 Programmable 360 Degrees Inclinometer");MODULE_LICENSE("GPL v2");MODULE_ALIAS("spi:adis16203");
Quoted 1 line · On Sun, 4 Feb 2018 16:31:24 +0000 Jonathan Cameron <[email protected]> wrote:
Here's a second driver reviewed...
Just for the record - in case someone comes across this at a later date - in the 16201 thread Nizam has 'grabbed' this one.
Quoted 411 lines
Vast majority of comments are the same as for the adis16201 driver.
The only real addition here is the nasty second inclinometer channel. It's just using a different range, so if you take the first and after it is greater than 180 degrees you instead make it negative, then you have the second channel.
My gut instinct is to drop reporting that channel at all. It doesn't add anything and it makes the userspace view of this hardware more complex.
Please read the 16201 review as well and the same suggestions apply on 'claiming' the driver if you want to clean it up.
Either way, both drivers should be straight forward to get ready for a staging graduation.
There are lots more features we 'could' support but absense of full support is not a reason to keep them in staging.
Thanks,
Jonathan
Quoted 6 lines
/*
* ADIS16203 Programmable 360 Degrees Inclinometer *
* Copyright 2010 Analog Devices Inc.
*
* Licensed under the GPL-2 or later.Might as well convert to SPDX format whilst we are working on the driver.
Quoted 10 lines
*/
#include <
linux/delay.h>
#include <linux/device.h>#include <
linux/iio/buffer.h>
#include <linux/iio/iio.h>
#include <linux/iio/imu/adis.h>
#include <linux/iio/sysfs.h>Quoted 6 lines
#include <
linux/kernel.h>
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/slab.h>
#include <linux/spi/spi.h>
#include <linux/sysfs.h>Put these into conventional header ordering.
Alphabetical with iio headers grouped at the end.Quoted 2 lines
#define
ADIS16203_STARTUP_DELAY220 /* ms */Include
_MSin the naming and drop the comment.Quoted 2 lines
/* Flash memory write count */
There are a lot of fairly 'obvious' comments here.
Add
_REGnaming to keep things consistent.
(see adis16201 review)Quoted 96 lines
#define
ADIS16203_FLASH_CNT0x00/* Output, power supply */
#defineADIS16203_SUPPLY_OUT0x02/* Output, auxiliary ADC input */
#defineADIS16203_AUX_ADC0x08/* Output, temperature */
#defineADIS16203_TEMP_OUT0x0A/* Output, x-axis inclination */
#defineADIS16203_XINCL_OUT0x0C/* Output, y-axis inclination */
#defineADIS16203_YINCL_OUT0x0E/* Incline null calibration */
#defineADIS16203_INCL_NULL0x18/* Alarm 1 amplitude threshold */
#defineADIS16203_ALM_MAG10x20/* Alarm 2 amplitude threshold */
#defineADIS16203_ALM_MAG20x22/* Alarm 1, sample period */
#defineADIS16203_ALM_SMPL10x24/* Alarm 2, sample period */
#defineADIS16203_ALM_SMPL20x26/* Alarm control */
#defineADIS16203_ALM_CTRL0x28/* Auxiliary DAC data */
#defineADIS16203_AUX_DAC0x30/* General-purpose digital input/output control */
#defineADIS16203_GPIO_CTRL0x32/* Miscellaneous control */
#defineADIS16203_MSC_CTRL0x34/* Internal sample period (rate) control */
#defineADIS16203_SMPL_PRD0x36/* Operation, filter configuration */
#defineADIS16203_AVG_CNT0x38/* Operation, sleep mode control */
#defineADIS16203_SLP_CNT0x3A/* Diagnostics, system status register */
#defineADIS16203_DIAG_STAT0x3C/* Operation, system command register */
#defineADIS16203_GLOB_CMD0x3E/*
MSC_CTRL*//* Self-test at power-on: 1 = disabled, 0 = enabled */
#defineADIS16203_MSC_CTRL_PWRUP_SELF_TESTBIT(10)/* Reverses rotation of both inclination outputs */
#defineADIS16203_MSC_CTRL_REVERSE_ROT_ENBIT(9)/* Self-test enable */
#defineADIS16203_MSC_CTRL_SELF_TEST_ENBIT(8)/* Data-ready enable: 1 = enabled, 0 = disabled */
#defineADIS16203_MSC_CTRL_DATA_RDY_ENBIT(2)/* Data-ready polarity: 1 = active high, 0 = active low */
#defineADIS16203_MSC_CTRL_ACTIVE_HIGHBIT(1)/* Data-ready line selection: 1 = DIO1, 0 = DIO0 */
#defineADIS16203_MSC_CTRL_DATA_RDY_DIO1BIT(0)/*
DIAG_STAT*//* Alarm 2 status: 1 = alarm active, 0 = alarm inactive */
#defineADIS16203_DIAG_STAT_ALARM2BIT(9)/* Alarm 1 status: 1 = alarm active, 0 = alarm inactive */
#defineADIS16203_DIAG_STAT_ALARM1BIT(8)/* Self-test diagnostic error flag */
#defineADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT5/* SPI communications failure */
#defineADIS16203_DIAG_STAT_SPI_FAIL_BIT3/* Flash update failure */
#defineADIS16203_DIAG_STAT_FLASH_UPT_BIT2Quoted 7 lines
/* Power supply above 3.625 V */
#defineADIS16203_DIAG_STAT_POWER_HIGH_BIT1/* Power supply below 3.15 V */
#defineADIS16203_DIAG_STAT_POWER_LOW_BIT0/*
GLOB_CMD*/See the adis16201 review for suggestions on how
to clean this up and drop unnecessary comemnts.Quoted 26 lines
#define ADIS16203_GLOB_CMD_SW_RESET BIT(7) #define ADIS16203_GLOB_CMD_CLEAR_STAT BIT(4) #define ADIS16203_GLOB_CMD_FACTORY_CAL BIT(1)#define
ADIS16203_ERROR_ACTIVEBIT(14)enum adis16203_scan { ADIS16203_SCAN_INCLI_X, ADIS16203_SCAN_INCLI_Y, ADIS16203_SCAN_SUPPLY, ADIS16203_SCAN_AUX_ADC, ADIS16203_SCAN_TEMP, };#define
DRIVER_NAME"adis16203"static const u8 adis16203_addresses[] = { [ADIS16203_SCAN_INCLI_X] = ADIS16203_INCL_NULL, };static int adis16203_write_raw(struct
iio_dev*indio_dev,
structiio_chan_specconst *chan, int val,
int val2,
long mask)Quoted 4 lines
{ struct adis *st = iio_priv(indio_dev); /* currently only one writable parameter which keeps this simple */ u8 addr = adis16203_addresses[chan->scan_index];However it needs error checking as nothing stops us trying to write to other parameters from userspace. So check it's what we expect.
Also that mask should be generated with GENMASK to make it more obvious what it covers.
Quoted 43 lines
return adis_write_reg_16(st, addr, val & 0x3FFF); }static int adis16203_read_raw(struct
iio_dev*indio_dev,
structiio_chan_specconst *chan, int *val, int *val2, long mask){ struct adis *st = iio_priv(indio_dev); int ret; int bits; u8 addr; s16 val16; switch (mask) { case IIO_CHAN_INFO_RAW: return adis_single_conversion(indio_dev, chan, ADIS16203_ERROR_ACTIVE, val); case IIO_CHAN_INFO_SCALE: switch (chan->type) { case IIO_VOLTAGE: if (chan->channel == 0) { *val = 1; *val2 = 220000; /* 1.22 mV */ } else { *val = 0; *val2 = 610000; /* 0.61 mV */ } return IIO_VAL_INT_PLUS_MICRO; case IIO_TEMP: *val = -470; /* -0.47 C */ *val2 = 0; return IIO_VAL_INT_PLUS_MICRO; case IIO_INCLI: *val = 0; *val2 = 25000; /* 0.025 degree */ return IIO_VAL_INT_PLUS_MICRO; default: return -EINVAL; } case IIO_CHAN_INFO_OFFSET: *val = 25000 / -470 - 1278; /* 25 C = 1278 */Quoted 8 lines
return IIO_VAL_INT; case IIO_CHAN_INFO_CALIBBIAS: bits = 14; addr = adis16203_addresses[chan->scan_index]; ret = adis_read_reg_16(st, addr, &val16); if (ret) return ret; val16 &= (1 << bits) - 1;Given sign extension, the masking shouldn't make any difference.
Quoted 1 line
val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);Simple sign extension. Just use the standard functions. Also go directly to 32bits and put it in val.
Quoted 7 lines
*val = val16; return IIO_VAL_INT; default: return -EINVAL; } }Quoted 6 lines
static const struct iio_chan_spec adis16203_channels[] = { ADIS_SUPPLY_CHAN(ADIS16203_SUPPLY_OUT, ADIS16203_SCAN_SUPPLY, 0, 12), ADIS_AUX_ADC_CHAN(ADIS16203_AUX_ADC, ADIS16203_SCAN_AUX_ADC, 0, 12), ADIS_INCLI_CHAN(X, ADIS16203_XINCL_OUT, ADIS16203_SCAN_INCLI_X, BIT(IIO_CHAN_INFO_CALIBBIAS), 0, 14), /* Fixme: Not what it appears to be - see data sheet */This is just an offset version of the previous channel. I would drop it as it doesn't add anything significant that userspace can't trivially compute.
Quoted 38 lines
ADIS_INCLI_CHAN(Y, ADIS16203_YINCL_OUT, ADIS16203_SCAN_INCLI_Y, 0, 0, 14), ADIS_TEMP_CHAN(ADIS16203_TEMP_OUT, ADIS16203_SCAN_TEMP, 0, 12), IIO_CHAN_SOFT_TIMESTAMP(5), };static const struct iio_info adis16203_info = { .read_raw = adis16203_read_raw, .write_raw = adis16203_write_raw, .update_scan_mode = adis_update_scan_mode, };static const char * const adis16203_status_error_msgs[] = { [ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT] = "Self test failure", [ADIS16203_DIAG_STAT_SPI_FAIL_BIT] = "SPI failure", [ADIS16203_DIAG_STAT_FLASH_UPT_BIT] = "Flash update failed", [ADIS16203_DIAG_STAT_POWER_HIGH_BIT] = "Power supply above 3.625V", [ADIS16203_DIAG_STAT_POWER_LOW_BIT] = "Power supply below 3.15V", };static const struct adis_data adis16203_data = { .read_delay = 20, .msc_ctrl_reg = ADIS16203_MSC_CTRL, .glob_cmd_reg = ADIS16203_GLOB_CMD, .diag_stat_reg = ADIS16203_DIAG_STAT, .self_test_mask = ADIS16203_MSC_CTRL_SELF_TEST_EN, .self_test_no_autoclear = true, .startup_delay = ADIS16203_STARTUP_DELAY, .status_error_msgs = adis16203_status_error_msgs, .status_error_mask = BIT(ADIS16203_DIAG_STAT_SELFTEST_FAIL_BIT) | BIT(ADIS16203_DIAG_STAT_SPI_FAIL_BIT) | BIT(ADIS16203_DIAG_STAT_FLASH_UPT_BIT) | BIT(ADIS16203_DIAG_STAT_POWER_HIGH_BIT) | BIT(ADIS16203_DIAG_STAT_POWER_LOW_BIT), };Quoted 7 lines
static int
adis16203_probe(struct spi_device *spi){ int ret; struct iio_dev *indio_dev; struct adis *st; /* setup the industrialio driver allocated elements */Comment only tells us the obvious...
Quoted 5 lines
indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; st = iio_priv(indio_dev); /* this is only used for removal purposes */As before, doesn't add much as comments go.
Quoted 44 lines
spi_set_drvdata(spi, indio_dev); indio_dev->name = spi->dev.driver->name; indio_dev->dev.parent = &spi->dev; indio_dev->channels = adis16203_channels; indio_dev->num_channels = ARRAY_SIZE(adis16203_channels); indio_dev->info = &adis16203_info; indio_dev->modes = INDIO_DIRECT_MODE; ret = adis_init(st, indio_dev, spi, &adis16203_data); if (ret) return ret; ret = adis_setup_buffer_and_trigger(st, indio_dev, NULL); if (ret) return ret; /* Get the device into a sane initial state */ ret = adis_initial_startup(st); if (ret) goto error_cleanup_buffer_trigger; ret = iio_device_register(indio_dev); if (ret) goto error_cleanup_buffer_trigger; return 0;
error_cleanup_buffer_trigger:adis_cleanup_buffer_and_trigger(st, indio_dev); return ret; }static int
adis16203_remove(struct spi_device *spi){ struct iio_dev *indio_dev = spi_get_drvdata(spi); struct adis *st = iio_priv(indio_dev); iio_device_unregister(indio_dev); adis_cleanup_buffer_and_trigger(st, indio_dev); return 0; }Quoted 8 lines
static struct spi_driver adis16203_driver = { .driver = { .name = "adis16203", }, .probe = adis16203_probe, .remove = adis16203_remove, };
module_spi_driver(adis16203_driver);Device tree binding etc should probably be added + match tables so that this is useable on modern boards and probes automatically etc.
Quoted 5 lines
MODULE_AUTHOR("Barry Song <[email protected]>");MODULE_DESCRIPTION("Analog Devices ADIS16203 Programmable 360 Degrees Inclinometer");MODULE_LICENSE("GPL v2");MODULE_ALIAS("spi:adis16203");--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html