Skip to contentSkip to conversation

net: Extra '_get' in declaration of arch_get_platform_mac_address

PATCH Applied Mathieu Malaterre 2 participants 2 messages Feb 7, 2018 – Feb 8, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: Extra '_get' in declaration of arch_get_platform_mac_address

In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."), two declarations were added:

  int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
  unsigned char *arch_get_platform_get_mac_address(void);

An extra '_get' was introduced in arch_get_platform_get_mac_address, remove it. Fix compile warning using W=1:

CC net/ethernet/eth.o
net/ethernet/eth.c:523:24: warning: no previous prototype for ‘arch_get_platform_mac_address’ [-Wmissing-prototypes]
unsigned char * __weak arch_get_platform_mac_address(void)

                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

AR net/ethernet/built-in.o

---
 include/linux/etherdevice.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/etherdevice.h +1 -1
index 263dbcad22fc..79563840c295 100644
@@ -31,7 +31,7 @@
 #ifdef __KERNEL__
 struct device;
 int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
-unsigned char *arch_get_platform_get_mac_address(void);
+unsigned char *arch_get_platform_mac_address(void);
 u32 eth_get_headlen(void *data, unsigned int max_len);
 __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev);
 extern const struct header_ops eth_header_ops;
Signature · 1 line
2.11.0
maintainer Applied
#1 lore raw

From: Mathieu Malaterre <[email protected]>
Date: Wed, 7 Feb 2018 20:35:00 +0100

Quoted 9 lines

In commit c7f5d105495a ("net: Add eth_platform_get_mac_address() helper."), two declarations were added:

  int eth_platform_get_mac_address(struct device *dev, u8 *mac_addr);
  unsigned char *arch_get_platform_get_mac_address(void);

An extra '_get' was introduced in arch_get_platform_get_mac_address, remove it. Fix compile warning using W=1:

Quoted 7 lines

CC net/ethernet/eth.o
net/ethernet/eth.c:523:24: warning: no previous prototype for ‘arch_get_platform_mac_address’ [-Wmissing-prototypes]
unsigned char * __weak arch_get_platform_mac_address(void)

                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

AR net/ethernet/built-in.o

I'm very surprised this warning didn't get triggered before.

That's really weird!

Applied, thank you.