Skip to contentSkip to conversation

latencytop: remove recipe

PATCH In review Alexander Kanavin 4 participants 6 messages Feb 8, 2018 – Feb 14, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 latencytop: remove recipe

Last commit and release were in 2009; website is down; it's a dead project.

---
 meta/conf/distro/include/distro_alias.inc          |  1 -
 meta/conf/distro/include/maintainers.inc           |  1 -
 .../packagegroup-core-tools-profile.bb             |  1 -
 ...-function-signatures-to-fix-prototype-mis.patch | 64 ----------------------
 .../latencytop-0.5/latencytop-fsync.patch          | 49 -----------------
 .../latencytop-0.5/latencytop-makefile.patch       | 43 ---------------
 meta/recipes-kernel/latencytop/latencytop_0.5.bb   | 32 -----------
 7 files changed, 191 deletions(-)
 delete mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch
 delete mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync.patch
 delete mode 100644 meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-makefile.patch
 delete mode 100644 meta/recipes-kernel/latencytop/latencytop_0.5.bb
meta/conf/distro/include/distro_alias.inc +0 -1
index 1a217daa390..8ec623befbd 100644
@@ -159,7 +159,6 @@ DISTRO_PN_ALIAS_pn-kern-tools-native = "Windriver"
 DISTRO_PN_ALIAS_pn-keymaps = "OE-Core"
 DISTRO_PN_ALIAS_pn-kf = "OSPDT"
 DISTRO_PN_ALIAS_pn-lame = "Debian=lame Ubuntu=lame"
-DISTRO_PN_ALIAS_pn-latencytop = "Meego=latencytop Fedora=latencytop Debian=latencytop OpenSuSE=latencytop"
 DISTRO_PN_ALIAS_pn-ldconfig-native = "Ubuntu=libc-bin Fedora=glibc"
 DISTRO_PN_ALIAS_pn-liba52 = "Mandriva=a52dec Debian=a52dec"
 DISTRO_PN_ALIAS_pn-libacpi = "Ubuntu=libacpi Mandriva=libacpi"
meta/conf/distro/include/maintainers.inc +0 -1
index 34f3d810051..9b25a112b75 100644
@@ -302,7 +302,6 @@ RECIPE_MAINTAINER_pn-kmod-native = "Chen Qi <[email protected]>"
 RECIPE_MAINTAINER_pn-kmscube = "Carlos Rafael Giani <[email protected]>"
 RECIPE_MAINTAINER_pn-l3afpad = "Maxin B. John <[email protected]>"
 RECIPE_MAINTAINER_pn-lame = "Tanu Kaskinen <[email protected]>"
-RECIPE_MAINTAINER_pn-latencytop = "Alexander Kanavin <[email protected]>"
 RECIPE_MAINTAINER_pn-ldconfig-native = "Khem Raj <[email protected]>"
 RECIPE_MAINTAINER_pn-less = "Yi Zhao <[email protected]>"
 RECIPE_MAINTAINER_pn-liba52 = "Tanu Kaskinen <[email protected]>"
meta/recipes-core/packagegroups/packagegroup-core-tools-profile.bb +0 -1
index a8e47da40cd..e3814a44bc2 100644
@@ -26,7 +26,6 @@ RRECOMMENDS_${PN} = "\
 
 PROFILETOOLS = "\
     powertop \
-    latencytop \
     "
 PERF = "perf"
 PERF_libc-musl = ""
meta/recipes-kernel/latencytop/latencytop-0.5/0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch deleted +0 -64

64 lines not on this page · raw message

meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-fsync.patch deleted +0 -49

49 lines not on this page · raw message

meta/recipes-kernel/latencytop/latencytop-0.5/latencytop-makefile.patch deleted +0 -43

43 lines not on this page · raw message

meta/recipes-kernel/latencytop/latencytop_0.5.bb deleted +0 -32
deleted file mode 100644
index eb19471ce8b..00000000000
@@ -1,32 +0,0 @@
-SUMMARY = "Linux tool for measuring and fixing latency"
-HOMEPAGE = "http://www.latencytop.org/"
-
-LICENSE = "GPLv2"
-LIC_FILES_CHKSUM = "file://latencytop.c;endline=23;md5=ee9ea9b1415356e5734adad4a87dc7fa"
-
-inherit pkgconfig
-
-DEPENDS = "virtual/libintl ncurses glib-2.0"
-
-PR = "r3"
-
-SRC_URI = "http://pkgs.fedoraproject.org/repo/pkgs/${BPN}/${BP}.tar.gz/73bb3371c6ee0b0e68e25289027e865c/${BP}.tar.gz \
-            file://latencytop-makefile.patch \
-            file://latencytop-fsync.patch \
-            file://0001-Rectify-the-function-signatures-to-fix-prototype-mis.patch \
-"
-
-SRC_URI[md5sum] = "73bb3371c6ee0b0e68e25289027e865c"
-SRC_URI[sha256sum] = "9e7f72fbea7bd918e71212a1eabaad8488d2c602205d2e3c95d62cd57e9203ef"
-
-PACKAGECONFIG ??= "${@bb.utils.filter('DISTRO_FEATURES', 'x11', d)}"
-
-PACKAGECONFIG[x11] = ",,gtk+"
-
-EXTRA_OEMAKE_X = "${@bb.utils.contains('PACKAGECONFIG', 'x11', 'HAS_GTK_GUI=1', '', d)}"
-
-#CFLAGS += "${LDFLAGS}"
-
-do_install() {
-    oe_runmake install DESTDIR=${D} ${EXTRA_OEMAKE_X}
-}
Signature · 1 line
2.15.1
#1 lore raw

PATCH 2/3 go: fix upstream version check

---
 meta/recipes-devtools/go/go-common.inc | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-devtools/go/go-common.inc +1 -0
index 9af68738a60..37138b51ed8 100644
@@ -17,6 +17,7 @@ inherit goarch
 SRC_URI = "http://golang.org/dl/go${PV}.src.tar.gz;name=main"
 S = "${WORKDIR}/go"
 B = "${S}"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.src\.tar"
 
 INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
 SSTATE_SCAN_CMD = "true"
Signature · 1 line
2.15.1
#2 lore raw

PATCH 3/3 python-numpy: fix upstream version check

In reply to Alexander Kanavin
---
 meta/recipes-devtools/python-numpy/python-numpy_1.13.1.bb  | 1 +
 meta/recipes-devtools/python-numpy/python3-numpy_1.13.3.bb | 1 +
 2 files changed, 2 insertions(+)
meta/recipes-devtools/python-numpy/python-numpy_1.13.1.bb +1 -0
index 13e8f4fa230..b6ec2308e41 100644
@@ -16,6 +16,7 @@ SRC_URI[md5sum] = "6d459e4a24f5035f720dda3c57716a92"
 SRC_URI[sha256sum] = "de020ec06f1e9ce1115a50161a38bf8d4c2525379900f9cb478cc613a1e7cd93"
 
 UPSTREAM_CHECK_URI = "https://github.com/numpy/numpy/releases"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
 
 CONFIGFILESURI ?= ""
 
meta/recipes-devtools/python-numpy/python3-numpy_1.13.3.bb +1 -0
index 277c21f9da4..553b0fac7f2 100644
@@ -15,6 +15,7 @@ SRC_URI[md5sum] = "c1d433e5973e548809e80c9118474b73"
 SRC_URI[sha256sum] = "4c6b4eef790528bebb7ec9590d74cc193868940fe68e4109a91c196df72d8094"
 
 UPSTREAM_CHECK_URI = "https://github.com/numpy/numpy/releases"
+UPSTREAM_CHECK_REGEX = "(?P<pver>\d+(\.\d+)+)\.tar"
 
 CONFIGFILESURI ?= ""
 
Signature · 1 line
2.15.1
#3 lore raw
In reply to Alexander Kanavin
Quoted 1 line · Alexander Kanavin

Last commit and release were in 2009; website is down; it's a dead project.

Add MarkA who might care/know more about latencytop than I do.

Is there another package that makes use of the kernel feature? The kernel Kconfig has been tweaked in 2017:

commit a34a766ff96d9e88572e35a45066279e40a85d84
Author: Josh Poimboeuf <[email protected]>
Date: Mon Jul 24 18:36:58 2017 -0500

x86/kconfig: Make it easier to switch to the new ORC unwinder

and there are people updating latencytop on github last year:
https://github.com/namhyung/latencytop/commits/master
commits on some random github page. That's shocking I know but it does indicate that there's still interest in the tool even if the original authors haven't been maintaining it.

../Randy

<snip>

Signature · 2 lines
# Randy MacLeod.  WR Linux
# Wind River an Intel Company
#4 lore raw
Quoted 5 lines · EST Randy MacLeod
Quoted 2 lines · Alexander Kanavin

Last commit and release were in 2009; website is down; it's a dead project.

Add MarkA who might care/know more about latencytop than I do.

I believe Bruce had already identified LatencyTop as a dead end by the time we even did our first release of OVP (I have no recollection of ever including it and there are 0 user stories in Rally which would validate my memories on this subject). Just in case I have added Bruce to the list. We already had LTTng and FTrace, including a mostly dead Intel project was not a priority if I recall correctly.

MarkA

Quoted 21 lines

Is there another package that makes use of the kernel feature? The kernel Kconfig has been tweaked in 2017:

commit a34a766ff96d9e88572e35a45066279e40a85d84
Author: Josh Poimboeuf <[email protected]>
Date: Mon Jul 24 18:36:58 2017 -0500

x86/kconfig: Make it easier to switch to the new ORC unwinder

and there are people updating latencytop on github last year:
https://github.com/namhyung/latencytop/commits/master
commits on some random github page. That's shocking I know but it does indicate that there's still interest in the tool even if the original authors haven't been maintaining it.

../Randy

<snip>

#5 lore raw
Quoted 5 lines · Mark Asselstine
Quoted 4 lines · EST Randy MacLeod
Quoted 2 lines · Alexander Kanavin

Last commit and release were in 2009; website is down; it's a dead project.

Quoted 9 lines
Quoted 1 line

Add MarkA who might care/know more about latencytop than I do.

I believe Bruce had already identified LatencyTop as a dead end by the time we even did our first release of OVP (I have no recollection of ever including it and there are 0 user stories in Rally which would validate my memories on this subject). Just in case I have added Bruce to the list. We already had LTTng and FTrace, including a mostly dead Intel project was not a priority if I recall correctly.

Not everything needs new features constantly, and if they aren't causing build issues .. I tend to be ok with keeping them around.

There are uses, and users for latencytop.

That being said, I can just add it to meta-realtime, and it can be dropped from core, since the userbase doesn't justify it in oe-core itself.

Cheers,

Bruce

Quoted 25 lines

MarkA

Quoted 21 lines

Is there another package that makes use of the kernel feature? The kernel Kconfig has been tweaked in 2017:

commit a34a766ff96d9e88572e35a45066279e40a85d84
Author: Josh Poimboeuf <[email protected]>
Date: Mon Jul 24 18:36:58 2017 -0500

x86/kconfig: Make it easier to switch to the new ORC unwinder

and there are people updating latencytop on github last year:
https://github.com/namhyung/latencytop/commits/master
commits on some random github page. That's shocking I know but it does indicate that there's still interest in the tool even if the original authors haven't been maintaining it.

../Randy

<snip>