Skip to contentSkip to conversation

option: Add support for Quectel EP06

DISCUSSION Johan Hovold 1 participant 1 message Feb 9, 2018 USB

lore
Share & tools
lore
#0 lore raw
Quoted 15 lines · Bjørn Mork
Quoted 9 lines · Johan Hovold
Quoted 5 lines

IIRC I considered just dumping the BIT(x) into the .driver_info but then we'd only have 16 bits for each of send_setup and reserved on 32- bit arches and I wasn't sure that was enough. I've seen some devices with lots of interfaces. But doing it this way might have been clearer than a sidecar struct like option_blacklist_info.

Yeah, we should probably consider moving over to something like that. 16 bits would at least be enough for the devices we currently have blacklists for.

Yes, I think the current driver documents pretty well that we don't need backlists for high interface numbers.

Quoted 7 lines

Checking the devices I have ever used, the only ones I found with interface numbers higher than 16 were the Sierra Wireless modems of the MDM9200/MDM9600 generation. THe used 19 and 20 for two of their QMI/RMNET functions. But they are handled by the qcserial driver, so that's not an issue wrt option.

I say go for the simple bitmasks!

Great, thanks for the feedback.

Quoted 3 lines

You might also consider a general blacklist for stuff like ADB which always need blacklisting. By now, Google owns ff/42/xx whether you like it or not.

Good point.

I won't be able to look at this for another few weeks myself, but will try to come with some fairly compact notation for this unless someone beats me to it.

Thanks,
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html