Skip to contentSkip to conversation

kernel-yocto: create dummy git user if necessary

PATCH In review Justin Bronder 2 participants 3 messages Feb 9, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel-yocto: create dummy git user if necessary

The user's global git configuration may not have the name and email set and git autodetection can fail. The initialization commit for a non-git kernel directory doesn't really need to be tied back to them anyways. Instead, create a user and email that's clearly tied back to kernel-yocto.bbclass.

---
 meta/classes/kernel-yocto.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/kernel-yocto.bbclass +2 -0
index 60979a218f..dbf01f86b6 100644
@@ -247,6 +247,8 @@ do_kernel_checkout() {
 		fi
 		rm -f .gitignore
 		git init
+		git config user.name 'Yocto Kernel Git Initializer'
+		git config user.email 'kernel-yocto.bbclass@invalid'
 		git add .
 		git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
 		git clean -d -f
Signature · 1 line
2.13.6
#1 lore raw
Quoted 16 lines · Justin Bronder

The user's global git configuration may not have the name and email set and git autodetection can fail. The initialization commit for a non-git kernel directory doesn't really need to be tied back to them anyways. Instead, create a user and email that's clearly tied back to kernel-yocto.bbclass.

---
 meta/classes/kernel-yocto.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/kernel-yocto.bbclass +0 -0
index 60979a218f..dbf01f86b6 100644

meta/classes/kernel-yocto.bbclass do_kernel_checkout() { · line 251

Quoted 5 lines
meta/classes/kernel-yocto.bbclass +2 -0
@@ -247,6 +247,8 @@ do_kernel_checkout() {
                fi
                rm -f .gitignore
                git init
+               git config user.name 'Yocto Kernel Git Initializer'
+               git config user.email 'kernel-yocto.bbclass@invalid'

This is already handled in the utility classes via the check_git_config routine and it is called in kernel-yocto's do_patch routine.

If it is needed earlier (as it appears it is), move that call to do_kernel_checkout.

Bruce

Quoted 11 lines
meta/classes/kernel-yocto.bbclass +0 -1
                git add .
                git commit -q -m "baseline commit: creating repo for ${PN}-${PV}"
                git clean -d -f
--

2.13.6

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
#2 lore raw
Quoted 28 lines · Bruce Ashfield
Quoted 16 lines · Justin Bronder

The user's global git configuration may not have the name and email set and git autodetection can fail. The initialization commit for a non-git kernel directory doesn't really need to be tied back to them anyways. Instead, create a user and email that's clearly tied back to kernel-yocto.bbclass.

---
 meta/classes/kernel-yocto.bbclass | 2 ++
 1 file changed, 2 insertions(+)
meta/classes/kernel-yocto.bbclass +0 -0
index 60979a218f..dbf01f86b6 100644

meta/classes/kernel-yocto.bbclass do_kernel_checkout() { · line 251

Quoted 5 lines
meta/classes/kernel-yocto.bbclass +2 -0
@@ -247,6 +247,8 @@ do_kernel_checkout() {
                fi
                rm -f .gitignore
                git init
+               git config user.name 'Yocto Kernel Git Initializer'
+               git config user.email 'kernel-yocto.bbclass@invalid'

This is already handled in the utility classes via the check_git_config routine and it is called in kernel-yocto's do_patch routine.

Quoted 2 lines

If it is needed earlier (as it appears it is), move that call to do_kernel_checkout.

Ah, didn't see that. Thanks. I'll send a new patch shortly.

Signature · 1 line
Justin Bronder