Skip to contentSkip to conversation

Log pre-handshake packet drops using D_MULTI_DROPPED

PATCH In review Steffan Karger 2 participants 2 messages Feb 11, 2018 – Feb 20, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Log pre-handshake packet drops using D_MULTI_DROPPED

We have a debug level packets dropped by the TLS layer - use that for this packet drop too. This changes this message from 'verb 3' to 'verb 4' (which should result in less user reports about this almost always harmless warning).

---
 src/openvpn/ssl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
src/openvpn/ssl.c +1 -1
index 676d0b90..d758c31a 100644
@@ -3361,7 +3361,7 @@ tls_pre_decrypt(struct tls_multi *multi,
                 {
                     if (!ks->crypto_options.key_ctx_bi.initialized)
                     {
-                        msg(D_TLS_DEBUG_LOW,
+                        msg(D_MULTI_DROPPED,
                             "Key %s [%d] not initialized (yet), dropping packet.",
                             print_link_socket_actual(from, &gc), key_id);
                         goto error_lite;
Signature · 1 line
2.14.1
Acked-by on v1 1/1
#1 lore raw

"because the reasoning make sense, and the code change is trivial enough"

Your patch has been applied to the master and release/2.4 branch.

commit c215c58f2393e881e16f9805549316a1e257a682 (master) commit 38595e9b1f337ee22a94154323eb14408ed86ef8 (release/2.4)

Author: Steffan Karger
Date:   Sun Feb 11 11:19:29 2018 +0100
     Log pre-handshake packet drops using D_MULTI_DROPPED

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg16477.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering