net: mii command: disable build for 64-bit Allwinner boards
RFC PATCH 1/1 net: mii command: disable build for 64-bit Allwinner boards
The current master fails to build some Allwinner H5 boards, due to exceeding the U-Boot proper size limit we currently have still in place. This affects:
- nanopi_neo2_defconfig
- nanopi_neo_plus2_defconfig
- orangepi_pc2_defconfig
- orangepi_prime_defconfig
- orangepi_zero_plus2_defconfig
To workaround this issue, a left-over low hanging fruit is to disable the MII *command*, which is probably only useful for debugging and not needed for a normal boot flow, even when booting via network (PXE/TFTP).
Allow to de-select CMD_MII, even when the distro default enables it. Then disable it explicitly in the affected board's defconfigs. This makes all Allwinner ARMv8 boards build again.
---
Hi,
my sincere apologies for this ugly hack (and I welcome any nicer solution!), but we are running out of silver bullets for this particular problem and this command seems both easy to give up and worthwhile in terms of code size savings (~11KB).
The "default n if ..." doesn't seem to work with "imply", so I needed to disable it in each of the affected defconfigs. Please let me know if there is a better solution.
Cheers,
Andre.
Kconfig | 2 +- cmd/Kconfig | 1 + configs/nanopi_neo2_defconfig | 1 + configs/nanopi_neo_plus2_defconfig | 1 + configs/orangepi_pc2_defconfig | 1 + configs/orangepi_prime_defconfig | 1 + configs/orangepi_zero_plus2_defconfig | 1 + configs/pine64_plus_defconfig | 1 + 8 files changed, 8 insertions(+), 1 deletion(-)
Kconfig +1 -1
@@ -75,7 +75,7 @@ config DISTRO_DEFAULTS select CMD_EXT4 select CMD_FAT select CMD_FS_GENERIC - select CMD_MII if NET + imply CMD_MII if NET select CMD_PING if NET select CMD_PART select HUSH_PARSER
cmd/Kconfig +1 -0
@@ -1017,6 +1017,7 @@ config CMD_NFS config CMD_MII bool "mii" + default n if ARCH_SUNXI && ARM64 help Enable MII utility commands.
configs/nanopi_neo2_defconfig +1 -0
@@ -7,6 +7,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo2" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
configs/nanopi_neo_plus2_defconfig +1 -0
@@ -9,6 +9,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-nanopi-neo-plus2" CONFIG_SPL=y # CONFIG_CMD_IMLS is not set # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
configs/orangepi_pc2_defconfig +1 -0
@@ -8,6 +8,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-pc2" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
configs/orangepi_prime_defconfig +1 -0
@@ -7,6 +7,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-prime" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
configs/orangepi_zero_plus2_defconfig +1 -0
@@ -9,6 +9,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-h5-orangepi-zero-plus2" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
configs/pine64_plus_defconfig +1 -0
@@ -6,6 +6,7 @@ CONFIG_DEFAULT_DEVICE_TREE="sun50i-a64-pine64-plus" # CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set CONFIG_SPL=y # CONFIG_CMD_FLASH is not set +# CONFIG_CMD_MII is not set # CONFIG_SPL_DOS_PARTITION is not set # CONFIG_SPL_ISO_PARTITION is not set # CONFIG_SPL_EFI_PARTITION is not set
Signature · 1 line
2.14.1
RFC PATCH 1/1 net: mii command: disable build for 64-bit Allwinner boards
Quoted 20 lines · Andre Przywara
The current master fails to build some Allwinner H5 boards, due to exceeding the U-Boot proper size limit we currently have still in place. This affects:
-nanopi_neo2_defconfig
-nanopi_neo_plus2_defconfig
-orangepi_pc2_defconfig
-orangepi_prime_defconfig
-orangepi_zero_plus2_defconfig
To workaround this issue, a left-over low hanging fruit is to disable the MII *command*, which is probably only useful for debugging and not needed for a normal boot flow, even when booting via network (PXE/TFTP).Allow to de-select
CMD_MII, even when the distro default enables it. Then disable it explicitly in the affected board's defconfigs. This makes all Allwinner ARMv8 boards build again.Signed-off-by Andre Przywara <[email protected]>---
Hi,
Quoted 7 lines
my sincere apologies for this ugly hack (and I welcome any nicer solution!), but we are running out of silver bullets for this particular problem and this command seems both easy to give up and worthwhile in terms of code size savings (~11KB).
The "default n if ..." doesn't seem to work with "imply", so I needed to disable it in each of the affected defconfigs. Please let me know if there is a better solution.
Can we not move the env location now? Thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180212/a3754c52/attachment.sig>
RFC PATCH 1/1 net: mii command: disable build for 64-bit Allwinner boards
Quoted 30 lines · Tom Rini
Quoted 20 lines · Andre Przywara
The current master fails to build some Allwinner H5 boards, due to exceeding the U-Boot proper size limit we currently have still in place. This affects:
-nanopi_neo2_defconfig
-nanopi_neo_plus2_defconfig
-orangepi_pc2_defconfig
-orangepi_prime_defconfig
-orangepi_zero_plus2_defconfig
To workaround this issue, a left-over low hanging fruit is to disable the MII *command*, which is probably only useful for debugging and not needed for a normal boot flow, even when booting via network (PXE/TFTP).Allow to de-select
CMD_MII, even when the distro default enables it. Then disable it explicitly in the affected board's defconfigs. This makes all Allwinner ARMv8 boards build again.Signed-off-by Andre Przywara <[email protected]>---
Hi,Quoted 7 lines
my sincere apologies for this ugly hack (and I welcome any nicer solution!), but we are running out of silver bullets for this particular problem and this command seems both easy to give up and worthwhile in terms of code size savings (~11KB).
The "default n if ..." doesn't seem to work with "imply", so I needed to disable it in each of the affected defconfigs. Please let me know if there is a better solution.
Quoted 1 line
Can we not move the env location now? Thanks!
Not yet, unfortunately. As of v2018.01 we store the environment in raw MMC still and need to obey the limit. The just merged multi-env support allows us to *transition* all users over to a FAT environment (because it will pickup the env from MMC, but save it in FAT by default). But we need at least one release to be nice to our users: v2018.03. In this time we still need to obey the limit, to not destroy the existing legacy env in MMC.
With v2018.05-rc1 we can then disable ENV_IS_IN_MMC and remove the limit.
So the end is nigh ;-), but not there yet.
Cheers,
Andre.