Skip to contentSkip to conversation

ARC: Don't check presense of Timer1 in SMP builds

PATCH In review Alexey Brodkin 2 participants 2 messages Feb 13, 2018 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARC: Don't check presense of Timer1 in SMP builds

In case of SMP we use GFRC from ARconnect and Timer1 is left untouched. Still with that check in place we're panicing if Timer1 is missing in current hardware which is quite unexpected.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
---
 arch/arc/kernel/setup.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arc/kernel/setup.c +2 -0
index cf97f7d88934..1142d76a7e8f 100644
@@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
 	if (!cpu->extn.timer0)
 		panic("Timer0 is not present!\n");
 
+#ifndef CONFIG_SMP
 	if (!cpu->extn.timer1)
 		panic("Timer1 is not present!\n");
+#endif
 
 #ifdef CONFIG_ARC_HAS_DCCM
 	/*
Signature · 1 line
2.11.0
#1 lore raw
Quoted 14 lines · Alexey Brodkin

In case of SMP we use GFRC from ARconnect and Timer1 is left untouched. Still with that check in place we're panicing if Timer1 is missing in current hardware which is quite unexpected.

Signed-off-by Alexey Brodkin <abrodkin at synopsys.com>
---
  arch/arc/kernel/setup.c | 2 ++
  1 file changed, 2 insertions(+)
arch/arc/kernel/setup.c +0 -0
index cf97f7d88934..1142d76a7e8f 100644

arch/arc/kernel/setup.c static void arc_chk_core_config(void) · line 397

Quoted 7 lines
arch/arc/kernel/setup.c +2 -0
@@ -391,8 +391,10 @@ static void arc_chk_core_config(void)
  	if (!cpu->extn.timer0)
  		panic("Timer0 is not present!\n");
 
+#ifndef CONFIG_SMP
  	if (!cpu->extn.timer1)
  		panic("Timer1 is not present!\n");
+#endif

Curious, you have a config w/o TIMER1, so is this a fallout of recent discussions !

-Vineet