Skip to contentSkip to conversation

x86/entry/64: use xorl for register clearing

PATCH Alexey Dobriyan 2 participants 2 messages Feb 14, 2018

lore
Share & tools
lore
#0 lore raw

Review

Quoted 2 lines
(quoted diff) +1 -1
-	xorq    %r8, %r8	/* nospec   r8 */
+	xorl	%r8d, %r8d	/* nospec   r8 */

The suffix should be simply dropped as operand size is unambigious. It is just one more character than necessary on the screen.

#1 lore raw
Quoted 5 lines · Alexey Dobriyan

Review

Quoted 2 lines
(quoted diff) +1 -1
-	xorq    %r8, %r8	/* nospec   r8 */
+	xorl	%r8d, %r8d	/* nospec   r8 */

The suffix should be simply dropped as operand size is unambigious. It is just one more character than necessary on the screen.

No strong feelings about this issue, but I prefer it to be explicit. And that's what seems to be the standard in arch/x86/entry/ .

Thanks,
Dominik