i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
Subsystems (3)
PATCH 1/1 i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
It seems this is a copy-paste error and that the proper variable to use in this particular case is _src_ instead of _dst_.
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
--- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40evf/i40evf_main.c +1 -1
@@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct i40evf_adapter *adapter,if (key->src) { filter->f.mask.tcp_spec.src_port |=cpu_to_be16 (0xffff ); - filter->f.data.tcp_spec.src_port = key->dst; + filter->f.data.tcp_spec.src_port = key->src; } } filter->f.field_flags = field_flags;
Signature · 1 line
2.7.4
Quoted 7 lines · Gustavo A. R. Silva
It seems this is a copy-paste error and that the proper variable to use
in this particular case is _src_ instead of _dst_.Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")Signed-off-by Gustavo A. R. Silva <[email protected]>
Thanks for the patch!
Quoted 20 lines
---
?drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- ?1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/intel/i40evf/i40evf_main.c +0
-0@@ -2763,7 +2763,7 @@ static int i40evf_parse_cls_flower(struct i40evf_adapter *adapter,?
? if (key->src) {
?filter->f.mask.tcp_spec.src_port|=cpu_to_be16(0xffff);drivers/net/ethernet/intel/i40evf/i40evf_main.c +1
-1- filter->f.data.tcp_spec.src_port = key->dst; + filter->f.data.tcp_spec.src_port = key->src;? }
? }
?filter->f.field_flags=field_flags;
Jeff Kirsher
Acked-byQuoted 5 lines · Harshitha
Quoted 4 lines · Gustavo A. R. Silva
It seems this is a copy-paste error and that the proper variable to use
in this particular case is _src_ instead of _dst_.
Quoted 7 lines
Quoted 3 lines
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")Signed-off-by Gustavo A. R. Silva <[email protected]>Thanks for the patch!
Dave, no need for me to pick this patch up and then push to you. You can circumvent me and pick this up.
Quoted 3 lines
Quoted 3 lines
--- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines · Jeff Kirsher
Quoted 5 lines · Harshitha
Quoted 4 lines · Gustavo A. R. Silva
It seems this is a copy-paste error and that the proper variable to use
in this particular case is _src_ instead of _dst_.
Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")Signed-off-by Gustavo A. R. Silva <[email protected]>Thanks for the patch!
Glad to help. :)
Quoted 10 lines
Quoted 1 line
Acked-by Jeff Kirsher <[email protected]>Dave, no need for me to pick this patch up and then push to you. You can circumvent me and pick this up.
Quoted 3 lines
Quoted 3 lines
--- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks guys.
--
Gustavo
Bowers
PATCH 1/1 i40evf/i40evf_main: Fix variable assignment in i40evf_parse_cls_flower
In reply to Gustavo A. R. SilvaQuoted 14 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Gustavo A. R. Silva
Sent: Thursday, February 15, 2018 9:45 AM
To: Ramamurthy, Harshitha <[email protected]>; Kirsher, Jeffrey T <[email protected]>
Cc: netdev at vger.kernel.org; intel-wired-lan at lists.osuosl.org; linux- kernel at vger.kernel.org; Gustavo A. R. Silva <[email protected]>
Subject: [Intel-wired-lan] [PATCH] i40evf/i40evf_main: Fix variable assignment ini40evf_parse_cls_flowerIt seems this is a copy-paste error and that the proper variable to use in this particular case is _src_ instead of _dst_.
Quoted 6 lines
Addresses-Coverity-ID: 1465282 ("Copy-paste error")
Fixes 0075fa0fadd0 ("i40evf: Add support to apply cloud filters")Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/net/ethernet/intel/i40evf/i40evf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)