staging: rtl8188eu: Fix "Missing a blank line after declaration".
PATCH 1/1 staging: rtl8188eu: Fix "Missing a blank line after declaration".
Fix checkpatch.pl "missing a blank line after declaration" warning message from rtl8188eu module.
---
text here is ignored by git tools.
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/hal/usb_halinit.c +1 -1
@@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)case HW_VAR_CAM_WRITE : {u32 cmd; -u32 *cam_val = (u32 *)val; +usb_write32 (Adapter,WCAMI , cam_val[0 ]); cmd =CAM_POLLINIG |CAM_WRITE | cam_val[1 ];
Signature · 1 line
2.7.4
Thanks for your patch, the first one submitted in this round :)
Quoted 1 line · Dafna Hirschfeld
Fix checkpatch.pl "missing a blank line after declaration" warning message from rtl8188eu module.
Your commit log message needs to stay within around 70 characters, so that it is within 80 when it gets slightly indented by git.
The subject line and the commit message should say what you have done and why, rather than just saying what you fixed, which could be done in many ways. A subject line could be "Move a blank line" and the commit log message could be
Move a blank line from in the middle of a declaration list to after the declaration list, to improve readability.
Problem detected using checkpatch.
Please send a v2.
julia
Quoted 33 lines
Signed-off-by Dafna Hirschfeld <[email protected]>---
text here is ignored by git tools.
drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/rtl8188eu/hal/usb_halinit.c +1
-2@@ -1516,8 +1516,8 @@ void rtw_hal_set_hwreg(struct adapter *Adapter, u8 variable, u8 *val)case HW_VAR_CAM_WRITE : {u32 cmd; -u32 *cam_val = (u32 *)val; +usb_write32 (Adapter,WCAMI , cam_val[0 ]); cmd =CAM_POLLINIG |CAM_WRITE | cam_val[1 ]; --2.7.4
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180215183900.GA12122%40gmail.com.
For more options, visit https://groups.google.com/d/optout.