Skip to contentSkip to conversation

Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

PATCH In review Yash Omer 3 participants 3 messages Feb 15, 2018 – Feb 16, 2018 Staging

lore
Share & tools
lore

Yash Omer

author
#0 lore raw

PATCH 1/1 Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c

This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.

---
 drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.c +2 -2
index 5be1af20d2d4..974a7572fafc 100644
@@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
 			goto exit;
 		}
 		/* ibss options */
-		result = hfa384x_drvr_setconfig16(hw,
-					HFA384x_RID_CREATEIBSS,
+		result = hfa384x_drvr_setconfig16
+					(hw, HFA384x_RID_CREATEIBSS,
 					HFA384x_CREATEIBSS_JOINCREATEIBSS);
 		if (result) {
 			netdev_err(wlandev->netdev,
Signature · 6 lines
2.14.3

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
maintainer
#1 lore raw
Quoted 12 lines · Yash Omer

This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.

---
 drivers/staging/wlan-ng/prism2mgmt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/wlan-ng/prism2mgmt.c +0 -0
index 5be1af20d2d4..974a7572fafc 100644

drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) · line 268

Quoted 7 lines
drivers/staging/wlan-ng/prism2mgmt.c +2 -2
@@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
 			goto exit;
 		}
 		/* ibss options */
-		result = hfa384x_drvr_setconfig16(hw,
-					HFA384x_RID_CREATEIBSS,
+		result = hfa384x_drvr_setconfig16
+					(hw, HFA384x_RID_CREATEIBSS,

The original code is just fine, why is checkpatch complaining about this?

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

#2 lore raw
Quoted 2 lines · Greg KH
Quoted 1 line · Yash Omer

This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.

[]

Quoted 1 line

drivers/staging/wlan-ng/prism2mgmt.c

Quoted 1 line
drivers/staging/wlan-ng/prism2mgmt.c +0 -0

[]

Quoted 11 lines

drivers/staging/wlan-ng/prism2mgmt.c int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp) · line 268

Quoted 8 lines
drivers/staging/wlan-ng/prism2mgmt.c +2 -2
@@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
 			goto exit;
 		}
 		/* ibss options */
-		result = hfa384x_drvr_setconfig16(hw,
-					HFA384x_RID_CREATEIBSS,
+		result = hfa384x_drvr_setconfig16
+					(hw, HFA384x_RID_CREATEIBSS,

The original code is just fine, why is checkpatch complaining about this?

lack of argument alignment to parentheses.

Maybe wlan-ng should be marked obsolete in MAINTAINERS.