fix double ;;s in code
Subsystems (23)
PATCH 1/1 fix double ;;s in code
Fix double ;;'s in code.
arch/arc/kernel/setup.c +1 -1
@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );
arch/arc/kernel/unwind.c +1 -1
@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }#ifdef CONFIG_MODULES
arch/arm/kernel/time.c +1 -1
@@ -83,7 +83,7 @@ static void dummy_clock_access(struct timespec64 *ts) }static clock_access_fn __read_persistent_clock = dummy_clock_access; -static clock_access_fn __read_boot_clock = dummy_clock_access;; +static clock_access_fn __read_boot_clock = dummy_clock_access;void read_persistent_clock64 (struct timespec64 *ts) {
arch/arm64/kernel/ptrace.c +1 -1
@@ -1419,7 +1419,7 @@ static int compat_ptrace_hbp_get(unsigned int note_type,u64 addr =0 ;u32 ctrl =0 ; -int err, idx =compat_ptrace_hbp_num_to_idx (num);; +int err, idx =compat_ptrace_hbp_num_to_idx (num);if (num &1 ) { err =ptrace_hbp_get_addr (note_type, tsk, idx, &addr);
arch/powerpc/kvm/book3s_xive.c +1 -1
@@ -188,7 +188,7 @@ static int xive_provision_queue(struct kvm_vcpu *vcpu, u8 prio)if (!qpage) {pr_err ("Failed to allocate queue %d for VCPU %d\n" , prio, xc->server_num); -return -ENOMEM ;; +return -ENOMEM ; }memset (qpage,0 ,1 << xive->q_order);
arch/powerpc/platforms/powernv/pci-ioda.c +1 -1
@@ -1854,7 +1854,7 @@ static int pnv_pci_ioda_dma_set_mask(struct pci_dev *pdev, u64 dma_mask)s64 rc;if (WARN_ON (!pdn || pdn->pe_number ==IODA_INVALID_PE )) -return -ENODEV ;; +return -ENODEV ; pe = &phb->ioda.pe_array[pdn->pe_number];if (pe->tce_bypass_enabled) {
arch/x86/boot/compressed/eboot.c +2 -2
@@ -439,7 +439,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u32 *handles = (u32 *)uga_handle;; +u32 *handles = (u32 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;
@@ -484,7 +484,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u64 *handles = (u64 *)uga_handle;; +u64 *handles = (u64 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;
block/sed-opal.c +1 -1
@@ -490,7 +490,7 @@ static int opal_discovery0_end(struct opal_dev *dev)if (!found_com_id) {pr_debug ("Could not find OPAL comid for device. Returning early\n" ); -return -EOPNOTSUPP ;; +return -EOPNOTSUPP ; } dev->comid = comid;
drivers/clocksource/mips-gic-timer.c +2 -2
@@ -205,12 +205,12 @@ static int __init gic_clocksource_of_init(struct device_node *node) }else if (of_property_read_u32 (node,"clock-frequency" , &gic_frequency)) {pr_err ("GIC frequency not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } gic_timer_irq =irq_of_parse_and_map (node,0 );if (!gic_timer_irq) {pr_err ("GIC timer IRQ not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } ret =__gic_clocksource_init ();
drivers/clocksource/timer-sun5i.c +1 -1
@@ -334,7 +334,7 @@ static int __init sun5i_timer_init(struct device_node *node) timer_base =of_io_request_and_map (node,0 ,of_node_full_name (node));if (IS_ERR (timer_base)) {pr_err ("Can't map registers\n" ); -return PTR_ERR (timer_base);; +return PTR_ERR (timer_base); } irq =irq_of_parse_and_map (node,0 );
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1 -1
@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);
drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1 -1
@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;
drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1 -1
@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);
drivers/gpu/drm/scheduler/gpu_scheduler.c +1 -1
@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {
drivers/iommu/intel-svm.c +1 -1
@@ -205,7 +205,7 @@ static void intel_flush_svm_range_dev (struct intel_svm *svm, struct intel_svm_d* for example, an "address" value of 0x12345f000 will * flush from 0x123440000 to 0x12347ffff (256KiB). */ unsigned long last = address + ((unsigned long )(pages -1 ) <<VTD_PAGE_SHIFT ); -unsigned long mask =__rounddown_pow_of_two (address ^ last);; +unsigned long mask =__rounddown_pow_of_two (address ^ last); desc.high =QI_DEV_EIOTLB_ADDR ((address & ~mask) | (mask -1 )) |QI_DEV_EIOTLB_SIZE ; }else {
drivers/md/raid1.c +1 -1
@@ -1108,7 +1108,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,bio_copy_data (behind_bio, bio); skip_copy: - r1_bio->behind_master_bio = behind_bio;; + r1_bio->behind_master_bio = behind_bio;set_bit (R1BIO_BehindIO, &r1_bio->state);return ;
drivers/soc/imx/gpc.c +1 -1
@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply); ret =imx_pgc_get_clocks (dev, domain);if (ret)
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>
A summary of the files modified on top of the patch would help understand the impact.
A maybe there should be one patch by area, eg one for each arch specific modif and one for drivers/ and one for block/ ?
Christophe
Quoted 230 lines
arch/arc/kernel/setup.c +1
-1@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );arch/arc/kernel/unwind.c +1
-1@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }#ifdef CONFIG_MODULES arch/arm/kernel/time.c +1
-1@@ -83,7 +83,7 @@ static void dummy_clock_access(struct timespec64 *ts) }static clock_access_fn __read_persistent_clock = dummy_clock_access; -static clock_access_fn __read_boot_clock = dummy_clock_access;; +static clock_access_fn __read_boot_clock = dummy_clock_access;void read_persistent_clock64 (struct timespec64 *ts) {arch/arm64/kernel/ptrace.c +1
-1@@ -1419,7 +1419,7 @@ static int compat_ptrace_hbp_get(unsigned int note_type,u64 addr =0 ;u32 ctrl =0 ; -int err, idx =compat_ptrace_hbp_num_to_idx (num);; +int err, idx =compat_ptrace_hbp_num_to_idx (num);if (num &1 ) { err =ptrace_hbp_get_addr (note_type, tsk, idx, &addr);arch/powerpc/kvm/book3s_xive.c +1
-1@@ -188,7 +188,7 @@ static int xive_provision_queue(struct kvm_vcpu *vcpu, u8 prio)if (!qpage) {pr_err ("Failed to allocate queue %d for VCPU %d\n" , prio, xc->server_num); -return -ENOMEM ;; +return -ENOMEM ; }memset (qpage,0 ,1 << xive->q_order);arch/powerpc/platforms/powernv/pci-ioda.c +1
-1@@ -1854,7 +1854,7 @@ static int pnv_pci_ioda_dma_set_mask(struct pci_dev *pdev, u64 dma_mask)s64 rc;if (WARN_ON (!pdn || pdn->pe_number ==IODA_INVALID_PE )) -return -ENODEV ;; +return -ENODEV ; pe = &phb->ioda.pe_array[pdn->pe_number];if (pe->tce_bypass_enabled) {arch/x86/boot/compressed/eboot.c +2
-2@@ -439,7 +439,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u32 *handles = (u32 *)uga_handle;; +u32 *handles = (u32 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;@@ -484,7 +484,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u64 *handles = (u64 *)uga_handle;; +u64 *handles = (u64 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;block/sed-opal.c +1
-1@@ -490,7 +490,7 @@ static int opal_discovery0_end(struct opal_dev *dev)if (!found_com_id) {pr_debug ("Could not find OPAL comid for device. Returning early\n" ); -return -EOPNOTSUPP ;; +return -EOPNOTSUPP ; } dev->comid = comid;drivers/clocksource/mips-gic-timer.c +2
-2@@ -205,12 +205,12 @@ static int __init gic_clocksource_of_init(struct device_node *node) }else if (of_property_read_u32 (node,"clock-frequency" , &gic_frequency)) {pr_err ("GIC frequency not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } gic_timer_irq =irq_of_parse_and_map (node,0 );if (!gic_timer_irq) {pr_err ("GIC timer IRQ not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } ret =__gic_clocksource_init ();drivers/clocksource/timer-sun5i.c +1
-1@@ -334,7 +334,7 @@ static int __init sun5i_timer_init(struct device_node *node) timer_base =of_io_request_and_map (node,0 ,of_node_full_name (node));if (IS_ERR (timer_base)) {pr_err ("Can't map registers\n" ); -return PTR_ERR (timer_base);; +return PTR_ERR (timer_base); } irq =irq_of_parse_and_map (node,0 );drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {drivers/iommu/intel-svm.c +1
-1@@ -205,7 +205,7 @@ static void intel_flush_svm_range_dev (struct intel_svm *svm, struct intel_svm_d* for example, an "address" value of 0x12345f000 will * flush from 0x123440000 to 0x12347ffff (256KiB). */ unsigned long last = address + ((unsigned long )(pages -1 ) <<VTD_PAGE_SHIFT ); -unsigned long mask =__rounddown_pow_of_two (address ^ last);; +unsigned long mask =__rounddown_pow_of_two (address ^ last); desc.high =QI_DEV_EIOTLB_ADDR ((address & ~mask) | (mask -1 )) |QI_DEV_EIOTLB_SIZE ; }else {drivers/md/raid1.c +1
-1@@ -1108,7 +1108,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,bio_copy_data (behind_bio, bio); skip_copy: - r1_bio->behind_master_bio = behind_bio;; + r1_bio->behind_master_bio = behind_bio;set_bit (R1BIO_BehindIO, &r1_bio->state);return ;drivers/soc/imx/gpc.c +0
-0
drivers/soc/imx/gpc.c static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, · line 354
Quoted 8 lines
drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply); ret =imx_pgc_get_clocks (dev, domain);if (ret)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>
A summary of the files modified on top of the patch would help understand the impact.
A maybe there should be one patch by area, eg one for each arch specific modif and one for drivers/ and one for block/ ?
Christophe
Quoted 230 lines
arch/arc/kernel/setup.c +1
-1@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );arch/arc/kernel/unwind.c +1
-1@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }#ifdef CONFIG_MODULES arch/arm/kernel/time.c +1
-1@@ -83,7 +83,7 @@ static void dummy_clock_access(struct timespec64 *ts) }static clock_access_fn __read_persistent_clock = dummy_clock_access; -static clock_access_fn __read_boot_clock = dummy_clock_access;; +static clock_access_fn __read_boot_clock = dummy_clock_access;void read_persistent_clock64 (struct timespec64 *ts) {arch/arm64/kernel/ptrace.c +1
-1@@ -1419,7 +1419,7 @@ static int compat_ptrace_hbp_get(unsigned int note_type,u64 addr =0 ;u32 ctrl =0 ; -int err, idx =compat_ptrace_hbp_num_to_idx (num);; +int err, idx =compat_ptrace_hbp_num_to_idx (num);if (num &1 ) { err =ptrace_hbp_get_addr (note_type, tsk, idx, &addr);arch/powerpc/kvm/book3s_xive.c +1
-1@@ -188,7 +188,7 @@ static int xive_provision_queue(struct kvm_vcpu *vcpu, u8 prio)if (!qpage) {pr_err ("Failed to allocate queue %d for VCPU %d\n" , prio, xc->server_num); -return -ENOMEM ;; +return -ENOMEM ; }memset (qpage,0 ,1 << xive->q_order);arch/powerpc/platforms/powernv/pci-ioda.c +1
-1@@ -1854,7 +1854,7 @@ static int pnv_pci_ioda_dma_set_mask(struct pci_dev *pdev, u64 dma_mask)s64 rc;if (WARN_ON (!pdn || pdn->pe_number ==IODA_INVALID_PE )) -return -ENODEV ;; +return -ENODEV ; pe = &phb->ioda.pe_array[pdn->pe_number];if (pe->tce_bypass_enabled) {arch/x86/boot/compressed/eboot.c +2
-2@@ -439,7 +439,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u32 *handles = (u32 *)uga_handle;; +u32 *handles = (u32 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;@@ -484,7 +484,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u64 *handles = (u64 *)uga_handle;; +u64 *handles = (u64 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;block/sed-opal.c +1
-1@@ -490,7 +490,7 @@ static int opal_discovery0_end(struct opal_dev *dev)if (!found_com_id) {pr_debug ("Could not find OPAL comid for device. Returning early\n" ); -return -EOPNOTSUPP ;; +return -EOPNOTSUPP ; } dev->comid = comid;drivers/clocksource/mips-gic-timer.c +2
-2@@ -205,12 +205,12 @@ static int __init gic_clocksource_of_init(struct device_node *node) }else if (of_property_read_u32 (node,"clock-frequency" , &gic_frequency)) {pr_err ("GIC frequency not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } gic_timer_irq =irq_of_parse_and_map (node,0 );if (!gic_timer_irq) {pr_err ("GIC timer IRQ not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } ret =__gic_clocksource_init ();drivers/clocksource/timer-sun5i.c +1
-1@@ -334,7 +334,7 @@ static int __init sun5i_timer_init(struct device_node *node) timer_base =of_io_request_and_map (node,0 ,of_node_full_name (node));if (IS_ERR (timer_base)) {pr_err ("Can't map registers\n" ); -return PTR_ERR (timer_base);; +return PTR_ERR (timer_base); } irq =irq_of_parse_and_map (node,0 );drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {drivers/iommu/intel-svm.c +1
-1@@ -205,7 +205,7 @@ static void intel_flush_svm_range_dev (struct intel_svm *svm, struct intel_svm_d* for example, an "address" value of 0x12345f000 will * flush from 0x123440000 to 0x12347ffff (256KiB). */ unsigned long last = address + ((unsigned long )(pages -1 ) <<VTD_PAGE_SHIFT ); -unsigned long mask =__rounddown_pow_of_two (address ^ last);; +unsigned long mask =__rounddown_pow_of_two (address ^ last); desc.high =QI_DEV_EIOTLB_ADDR ((address & ~mask) | (mask -1 )) |QI_DEV_EIOTLB_SIZE ; }else {drivers/md/raid1.c +1
-1@@ -1108,7 +1108,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,bio_copy_data (behind_bio, bio); skip_copy: - r1_bio->behind_master_bio = behind_bio;; + r1_bio->behind_master_bio = behind_bio;set_bit (R1BIO_BehindIO, &r1_bio->state);return ;drivers/soc/imx/gpc.c +0
-0
drivers/soc/imx/gpc.c static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, · line 354
Quoted 8 lines
drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply); ret =imx_pgc_get_clocks (dev, domain);if (ret)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 6 lines · Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 3 lines
Fix double ;;'s in code.
Quoted 7 lines
Quoted 1 line
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?
Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Then scripts/get_maintainers.pl will also give you a more focues list of relevant people for each part.
-Daniel
Quoted 217 lines
Christophe
Quoted 214 lines
arch/arc/kernel/setup.c +1
-1@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );arch/arc/kernel/unwind.c +1
-1@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }#ifdef CONFIG_MODULES arch/arm/kernel/time.c +1
-1@@ -83,7 +83,7 @@ static void dummy_clock_access(struct timespec64 *ts) }static clock_access_fn __read_persistent_clock = dummy_clock_access; -static clock_access_fn __read_boot_clock = dummy_clock_access;; +static clock_access_fn __read_boot_clock = dummy_clock_access;void read_persistent_clock64 (struct timespec64 *ts) {arch/arm64/kernel/ptrace.c +1
-1@@ -1419,7 +1419,7 @@ static int compat_ptrace_hbp_get(unsigned int note_type,u64 addr =0 ;u32 ctrl =0 ; -int err, idx =compat_ptrace_hbp_num_to_idx (num);; +int err, idx =compat_ptrace_hbp_num_to_idx (num);if (num &1 ) { err =ptrace_hbp_get_addr (note_type, tsk, idx, &addr);arch/powerpc/kvm/book3s_xive.c +1
-1@@ -188,7 +188,7 @@ static int xive_provision_queue(struct kvm_vcpu *vcpu, u8 prio)if (!qpage) {pr_err ("Failed to allocate queue %d for VCPU %d\n" , prio, xc->server_num); -return -ENOMEM ;; +return -ENOMEM ; }memset (qpage,0 ,1 << xive->q_order);arch/powerpc/platforms/powernv/pci-ioda.c +1
-1@@ -1854,7 +1854,7 @@ static int pnv_pci_ioda_dma_set_mask(struct pci_dev *pdev, u64 dma_mask)s64 rc;if (WARN_ON (!pdn || pdn->pe_number ==IODA_INVALID_PE )) -return -ENODEV ;; +return -ENODEV ; pe = &phb->ioda.pe_array[pdn->pe_number];if (pe->tce_bypass_enabled) {arch/x86/boot/compressed/eboot.c +2
-2@@ -439,7 +439,7 @@ setup_uga32(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u32 *handles = (u32 *)uga_handle;; +u32 *handles = (u32 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;@@ -484,7 +484,7 @@ setup_uga64(void **uga_handle, unsigned long size, u32 *width, u32 *height)struct efi_uga_draw_protocol *uga =NULL , *first_uga;efi_guid_t uga_proto =EFI_UGA_PROTOCOL_GUID ;unsigned long nr_ugas; -u64 *handles = (u64 *)uga_handle;; +u64 *handles = (u64 *)uga_handle;efi_status_t status =EFI_INVALID_PARAMETER ;int i;block/sed-opal.c +1
-1@@ -490,7 +490,7 @@ static int opal_discovery0_end(struct opal_dev *dev)if (!found_com_id) {pr_debug ("Could not find OPAL comid for device. Returning early\n" ); -return -EOPNOTSUPP ;; +return -EOPNOTSUPP ; } dev->comid = comid;drivers/clocksource/mips-gic-timer.c +2
-2@@ -205,12 +205,12 @@ static int __init gic_clocksource_of_init(struct device_node *node) }else if (of_property_read_u32 (node,"clock-frequency" , &gic_frequency)) {pr_err ("GIC frequency not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } gic_timer_irq =irq_of_parse_and_map (node,0 );if (!gic_timer_irq) {pr_err ("GIC timer IRQ not specified.\n" ); -return -EINVAL ;; +return -EINVAL ; } ret =__gic_clocksource_init ();drivers/clocksource/timer-sun5i.c +1
-1@@ -334,7 +334,7 @@ static int __init sun5i_timer_init(struct device_node *node) timer_base =of_io_request_and_map (node,0 ,of_node_full_name (node));if (IS_ERR (timer_base)) {pr_err ("Can't map registers\n" ); -return PTR_ERR (timer_base);; +return PTR_ERR (timer_base); } irq =irq_of_parse_and_map (node,0 );drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {drivers/iommu/intel-svm.c +1
-1@@ -205,7 +205,7 @@ static void intel_flush_svm_range_dev (struct intel_svm *svm, struct intel_svm_d* for example, an "address" value of 0x12345f000 will * flush from 0x123440000 to 0x12347ffff (256KiB). */ unsigned long last = address + ((unsigned long )(pages -1 ) <<VTD_PAGE_SHIFT ); -unsigned long mask =__rounddown_pow_of_two (address ^ last);; +unsigned long mask =__rounddown_pow_of_two (address ^ last); desc.high =QI_DEV_EIOTLB_ADDR ((address & ~mask) | (mask -1 )) |QI_DEV_EIOTLB_SIZE ; }else {drivers/md/raid1.c +1
-1@@ -1108,7 +1108,7 @@ static void alloc_behind_master_bio(struct r1bio *r1_bio,bio_copy_data (behind_bio, bio); skip_copy: - r1_bio->behind_master_bio = behind_bio;; + r1_bio->behind_master_bio = behind_bio;set_bit (R1BIO_BehindIO, &r1_bio->state);return ;drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply); ret =imx_pgc_get_clocks (dev, domain);if (ret)
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
Quoted 6 lines
Quoted 2 lines
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
If you don't care ... well I don't care either.
drivers/gpu/ has four entries, i guess that's something for you.
Pavel
Quoted 48 lines
Quoted 48 lines
Quoted 48 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
Quoted 6 lines
Quoted 2 lines
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
If you don't care ... well I don't care either.
drivers/gpu/ has four entries, i guess that's something for you.
Pavel
Quoted 48 lines
Quoted 48 lines
Quoted 48 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
Quoted 6 lines
Quoted 2 lines
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
If you don't care ... well I don't care either.
drivers/gpu/ has four entries, i guess that's something for you.
Pavel
Quoted 48 lines
Quoted 48 lines
Quoted 48 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp; -int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 23 lines · Pavel Machek
Quoted 12 lines · Daniel Vetter
Quoted 11 lines · Christophe LEROY
Quoted 4 lines · Pavel Machek
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
Quoted 6 lines
Quoted 2 lines
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
Quoted 6 lines
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
If you don't care ... well I don't care either.
drivers/gpu/has four entries, i guess that's something for you.
fwiw, one of those four is dup of a patch that I've already pushed to msm-next for drm/msm (which seems to be an argument for splitting up a treewide patch.. which seems something quite scriptable, but up to you whether you want to bother with that.. either way drm/msm is ;;-clean now)
BR,
-R
Quoted 46 lines
Pavel
Quoted 44 lines
Quoted 44 lines
Quoted 44 lines
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c +1
-1@@ -718,7 +718,7 @@ static enum link_training_result perform_channel_equalization_sequence(uint32_t retries_ch_eq;enum dc_lane_count lane_count = lt_settings->link_settings.lane_count;union lane_align_status_updated dpcd_lane_status_updated = {{0 }}; -union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}};; +union lane_status dpcd_lane_status[LANE_COUNT_DP_MAX ] = {{{0 }}}; hw_tr_pattern =get_supported_tp (link);drivers/gpu/drm/amd/powerplay/amd_powerplay.c +1
-1@@ -162,7 +162,7 @@ static int pp_hw_init(void *handle)if (hwmgr->smumgr_funcs->start_smu (pp_handle->hwmgr)) {pr_err ("smc start failed\n" ); hwmgr->smumgr_funcs->smu_fini (pp_handle->hwmgr); -return -EINVAL ;; +return -EINVAL ; }if (ret ==PP_DPM_DISABLED ) goto exit;drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c +1
-1@@ -680,7 +680,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) }else {dev_info (&pdev->dev,"no iommu, fallback to phys contig buffers for scanout\n" ); - aspace =NULL ;; + aspace =NULL ; }pm_runtime_put_sync (&pdev->dev);drivers/gpu/drm/scheduler/gpu_scheduler.c +0
-0@@ -461,7 +461,7 @@ void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo {struct drm_sched_job *s_job;struct drm_sched_entity *entity, *tmp;
Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
drivers/gpu/drm/scheduler/gpu_scheduler.c void drm_sched_hw_job_reset(struct drm_gpu_scheduler *sched, struct drm_sched_jo · line 467
Quoted 4 lines
drivers/gpu/drm/scheduler/gpu_scheduler.c +1
-1-int i;; +int i;spin_lock (&sched->job_list_lock);list_for_each_entry_reverse (s_job, &sched->ring_mirror_list, node) {--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 22 lines · Pavel Machek
Fix double ;;'s in code.
Signed-off-by Pavel Machek<[email protected]>arch/arc/kernel/setup.c +1
-1@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );arch/arc/kernel/unwind.c +0
-0
arch/arc/kernel/unwind.c static void init_unwind_hdr(struct unwind_table *table, · line 371
Quoted 7 lines
arch/arc/kernel/unwind.c +1
-1@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }
I have a fix from Luis to same effect from Jan sitting in my for-curr
Thx for it anyways.
-Vineet
Quoted 22 lines · Pavel Machek
Fix double ;;'s in code.
Signed-off-by Pavel Machek<[email protected]>arch/arc/kernel/setup.c +1
-1@@ -373,7 +373,7 @@ static void arc_chk_core_config(void) {struct cpuinfo_arc *cpu = &cpuinfo_arc700[smp_processor_id ()];int saved =0 , present =0 ; -char *opt_nm =NULL ;; +char *opt_nm =NULL ;if (!cpu->extn.timer0)panic ("Timer0 is not present!\n" );arch/arc/kernel/unwind.c +0
-0
arch/arc/kernel/unwind.c static void init_unwind_hdr(struct unwind_table *table, · line 371
Quoted 7 lines
arch/arc/kernel/unwind.c +1
-1@@ -366,7 +366,7 @@ static void init_unwind_hdr(struct unwind_table *table,return ; ret_err: -panic ("Attention !!! Dwarf FDE parsing errors\n" );; +panic ("Attention !!! Dwarf FDE parsing errors\n" ); }
I have a fix from Luis to same effect from Jan sitting in my for-curr
Thx for it anyways.
-Vineet
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Michael Ellerman
reviewerQuoted 10 lines · Daniel Vetter
Quoted 9 lines · Christophe LEROY
Le 17/02/2018 à 22:19, Pavel Machek a écrit :
Quoted 4 lines
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
Quoted 6 lines
Quoted 2 lines
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
This part is actually pretty annoying.
I hacked up a script (below) which seems to do a reasonable job in most cases.
For this patch it gives:
$ for f in $(git ls-files -m); do ./guess-prefix.py $f; done ARC: ARC: ARM: arm64: ptrace: KVM: PPC: powerpc/powernv: x86/efi: block/sed-opal: clocksource: mips-gic: clocksource/drivers/sun5i: drm/amd/display: drm/amd/powerplay: drm/msm/mdp5: drm: iommu/vt-d: md: soc: imx: gpc:
I think those are correct except for:
- "drm:" for "drivers/gpu/drm/scheduler" which has only a single commit.
- "md:" for "drivers/md/raid1.c" which is tricked by inconsistent
usage of "md: raid1:" and "md/raid1:".
But that seems like a reasonable hit rate.
Another approach would be to have a file that defines for each subsystem what the preferred style is, but that is likely to be a PITA to maintain.
cheers
#!/usr/bin/python3
import sys
import re
from subprocess import check_output
from collections import Counter
if len(sys.argv) != 2:
print('Usage: %s <path>' % sys.argv[0], file=sys.stderr)
sys.exit(1)fname = sys.argv[1]
cmd = ['git', 'log', '--format=%s', '-n', '100', fname] output = check_output(cmd).decode('utf-8')
ignore = ['License', 'Merge']
# Ordered list of patterns
patterns = [
# Common style "foo/bar/baz: Fix the foo"
re.compile('^([\w\-_]+: )+'),
# Less common "foo bar baz: Fix the foo"
re.compile('^([\w\-_]+:? )+: ')
]
words = []
for line in output.splitlines():
prefix = line.split()[0]
for patt in patterns:
match = patt.search(line)
if match:
prefix = match.group(0)
break
if prefix in ignore:
continue
words.append(prefix)
# Warn if we didn't find many examples
if len(words) < 5:
print("Warning: only found %d previous commits to guess from for" % len(words),
fname, file=sys.stderr)
counts = Counter(words)
print(counts.most_common(1)[0][0])
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Quoted 5 lines · Pavel Machek
Quoted 3 lines · Daniel Vetter
Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Quoted 7 lines
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
If you don't care ... well I don't care either.
Look, if this causes just one conflict down the line because it touches the kernel all over the place, then IMO it already wasn't worth it. Merge conflicts are inevitable, but there's no reason to make life harder just to cater for a cleanup patch. It's not that important.
Had it been split up, the drm parts would've been merged already.
BR,
Jani.
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 12 lines · Jani Nikula
Quoted 11 lines · Pavel Machek
Quoted 3 lines · Daniel Vetter
Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
Quoted 8 lines
Quoted 1 line
If you don't care ... well I don't care either.
Look, if this causes just one conflict down the line because it touches the kernel all over the place, then IMO it already wasn't worth it. Merge conflicts are inevitable, but there's no reason to make life harder just to cater for a cleanup patch. It's not that important.
Had it been split up, the drm parts would've been merged already.
FWIW, the amdgpu and scheduler changes have already been fixed for -next.
Alex
Quoted 10 lines
BR,
Jani.--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 14 lines · Michael Ellerman
Quoted 13 lines · Daniel Vetter
Quoted 11 lines · Christophe LEROY
Quoted 4 lines · Pavel Machek
Fix double ;;'s in code.
Signed-off-by Pavel Machek <[email protected]>A summary of the files modified on top of the patch would help understand the impact.
A maybe there should be one patch by area, eg one for each arch specific modif and one for
drivers/and one forblock/?
Quoted 8 lines
Quoted 3 lines
Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
This part is actually pretty annoying.
I hacked up a script (below) which seems to do a reasonable job in most cases.
Here was another suggestion from awhile ago
https://lkml.org/lkml/2010/11/16/245
Quoted 12 lines · On Tue, 20 Feb 2018 10:03:56 +0200 Jani Nikula <[email protected]>…
Quoted 11 lines · Pavel Machek
Quoted 3 lines · Daniel Vetter
Yeah, pls split this into one patch per area, with a suitable patch subject prefix. Look at git log of each file to get a feeling for what's the standard in each area.
Yeah I can spend hour spliting it, and then people will ignore it anyway.
If you care about one of the files being modified, please fix the bug, ";;" is a clear bug.
Quoted 8 lines
Quoted 1 line
If you don't care ... well I don't care either.
Look, if this causes just one conflict down the line because it touches the kernel all over the place, then IMO it already wasn't worth it. Merge conflicts are inevitable, but there's no reason to make life harder just to cater for a cleanup patch. It's not that important.
Had it been split up, the drm parts would've been merged already.
I just stage patches like this behind linux-next. So if your stuff in in -next, you'll never notice a thing.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Pavel,
On Sat, Feb 17, 2018 at 10:19:55PM +0100, Pavel Machek wrote:
...
Quoted 6 lines
drivers/soc/imx/gpc.c +0
-0
drivers/soc/imx/gpc.c static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, · line 354
Quoted 8 lines
drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply); ret =imx_pgc_get_clocks (dev, domain);if (ret)
Considering the controversy how the changes should be merged, I'm going to send a separate patch just for IMX GPC driver with a reported-by-you tag. Thanks for catching this.
Shawn
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Hi!
Quoted 11 lines
Quoted 11 lines
drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply);
Quoted 7 lines
drivers/soc/imx/gpc.c static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, · line 354
Quoted 3 lines
drivers/soc/imx/gpc.c +0
-0ret =imx_pgc_get_clocks (dev, domain);if (ret)Considering the controversy how the changes should be merged, I'm going to send a separate patch just for IMX GPC driver with a reported-by-you tag. Thanks for catching this.
That works for me.
Alternatively... Andrew Morton merged the patch to his -mm tree (thanks!), so you don't need to take any action, and it will be eventually fixed.
If you merge your own version of the patch, that's ok, too, since Andrew will just drop his version.
Best regards,
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 21 lines · Pavel Machek
Hi!
Quoted 11 lines
Quoted 11 lines
drivers/soc/imx/gpc.c +1
-1@@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap,if (i ==1 ) { domain->supply =devm_regulator_get (dev,"pu" );if (IS_ERR (domain->supply)) -return PTR_ERR (domain->supply);; +return PTR_ERR (domain->supply);Quoted 7 lines
drivers/soc/imx/gpc.c static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, · line 354
Quoted 3 lines
drivers/soc/imx/gpc.c +0
-0ret =imx_pgc_get_clocks (dev, domain);if (ret)Considering the controversy how the changes should be merged, I'm going to send a separate patch just for IMX GPC driver with a reported-by-you tag. Thanks for catching this.
Quoted 5 lines
That works for me.
Alternatively... Andrew Morton merged the patch to his -mm tree (thanks!), so you don't need to take any action, and it will be eventually fixed.
Okay, I'm dropping my patch from IMX tree.
Shawn
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel