Skip to contentSkip to conversation

auxdisplay: panel: Change comments to silence fallthrough warnings

PATCH In review Miguel Ojeda 1 participant 1 message Feb 19, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 auxdisplay: panel: Change comments to silence fallthrough warnings

Compiling with W=1 with gcc 7.2.0 gives 3 warnings like:

drivers/auxdisplay/panel.c: In function ‘panel_process_inputs’:
drivers/auxdisplay/panel.c:1374:17: warning: this statement may fall through [-Wimplicit-fallthrough=]

Cc Willy Tarreau <[email protected]>
Cc Geert Uytterhoeven <[email protected]>

---
I saw this while fixing the ones reported by the build service. I will queue it up for 4.17.

 drivers/auxdisplay/panel.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/auxdisplay/panel.c +3 -3
index ea7869c0d7f9..b7bb118f1497 100644
@@ -1372,7 +1372,7 @@ static void panel_process_inputs(void)
 				break;
 			input->rise_timer = 0;
 			input->state = INPUT_ST_RISING;
-			/* no break here, fall through */
+			/* fallthrough */
 		case INPUT_ST_RISING:
 			if ((phys_curr & input->mask) != input->value) {
 				input->state = INPUT_ST_LOW;
@@ -1385,11 +1385,11 @@ static void panel_process_inputs(void)
 			}
 			input->high_timer = 0;
 			input->state = INPUT_ST_HIGH;
-			/* no break here, fall through */
+			/* fallthrough */
 		case INPUT_ST_HIGH:
 			if (input_state_high(input))
 				break;
-			/* no break here, fall through */
+			/* fallthrough */
 		case INPUT_ST_FALLING:
 			input_state_falling(input);
 		}
Signature · 1 line
2.14.1