Skip to contentSkip to conversation

staging: rtl8188eu: Remove unneeded cast

PATCH-next Christopher Diaz Riveros 2 participants 2 messages Feb 20, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Fix Coccinelle alert:

drivers/staging//rtl8188eu/os_dep/usb_intf.c:336:13-27: WARNING: casting value returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.

---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/os_dep/usb_intf.c +1 -1
index 32c7225a831e..127ecf896fc9 100644
@@ -333,7 +333,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
 	struct net_device *pmondev;
 	int status = _FAIL;
 
-	padapter = (struct adapter *)vzalloc(sizeof(*padapter));
+	padapter = vzalloc(sizeof(*padapter));
 	if (padapter = NULL)
 		goto exit;
 	padapter->dvobj = dvobj;
Signature · 1 line
2.16.2
Acked-by
#1 lore raw
Quoted 7 lines · Christopher Diaz Riveros

Fix Coccinelle alert:

drivers/staging//rtl8188eu/os_dep/usb_intf.c:336:13-27: WARNING: casting value returned by memory allocation function to (struct adapter *) is useless.

This issue was detected by using the Coccinelle software.

Quoted 18 lines
---
  drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8188eu/os_dep/usb_intf.c +1 -1
index 32c7225a831e..127ecf896fc9 100644
@@ -333,7 +333,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj,
  	struct net_device *pmondev;
  	int status = _FAIL;
 
-	padapter = (struct adapter *)vzalloc(sizeof(*padapter));
+	padapter = vzalloc(sizeof(*padapter));
  	if (padapter = NULL)
  		goto exit;
  	padapter->dvobj = dvobj;