xfs_scrub: don't ask user to run xfs_repair for only warnings
PATCH 1/1 xfs_scrub: don't ask user to run xfs_repair for only warnings
From: Darrick J. Wong <[email protected]>
Don't advise the user to run xfs_repair on a filesystem that triggers warnings but no errors; there's no corruption for it to fix.
Signed-off-by Darrick J. Wong <[email protected]>
--- scrub/xfs_scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scrub/xfs_scrub.c +1 -1
@@ -514,7 +514,7 @@ report_outcome(fprintf (stderr,_ ("%s: errors found: %llu; warnings found: %llu\n" ), ctx->mntpoint, total_errors, ctx->warnings_found); -if (ctx->need_repair) +if (ctx->need_repair && total_errors >0 )fprintf (stderr,_ ("%s: Unmount and run xfs_repair.\n" ), ctx->mntpoint); }
Quoted 6 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
Don't advise the user to run
xfs_repairon a filesystem that triggers warnings but no errors; there's no corruption for it to fix.Signed-off-by Darrick J. Wong <[email protected]>
looks fine.
Reviewed-by Bill O'Donnell <[email protected]>
Quoted 21 lines
--- scrub/xfs_scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scrub/xfs_scrub.c +1
-2@@ -514,7 +514,7 @@ report_outcome(fprintf (stderr,_ ("%s: errors found: %llu; warnings found: %llu\n" ), ctx->mntpoint, total_errors, ctx->warnings_found); -if (ctx->need_repair) +if (ctx->need_repair && total_errors >0 )fprintf (stderr,_ ("%s: Unmount and run xfs_repair.\n" ), ctx->mntpoint); } --To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html