Skip to contentSkip to conversation

pcf85063 was not clearing bits correctly in pcf85063_start_clock

PATCH Applied Michael McCormick 2 participants 2 messages Feb 21, 2018 – Mar 13, 2018 Real time clock (RTC)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcf85063 was not clearing bits correctly in pcf85063_start_clock

Bit clear operation was missing ~

---
 drivers/rtc/rtc-pcf85063.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-pcf85063.c +1 -1
index a06dff9..67bc763 100644
@@ -70,7 +70,7 @@ static int pcf85063_start_clock(struct i2c_client *client, u8 ctrl1)
 	s32 ret;
 
 	/* start the clock */
-	ctrl1 &= PCF85063_REG_CTRL1_STOP;
+	ctrl1 &= ~PCF85063_REG_CTRL1_STOP;
 
 	ret = i2c_smbus_write_byte_data(client, PCF85063_REG_CTRL1, ctrl1);
 	if (ret < 0) {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 7 lines · Michael McCormick

Bit clear operation was missing ~

---
 drivers/rtc/rtc-pcf85063.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Signature · 3 lines
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com