Skip to contentSkip to conversation

soc: qcom: qmi: add CONFIG_NET dependency

PATCH In review Arnd Bergmann 2 participants 2 messages Feb 22, 2018 – Mar 9, 2018

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: qcom: qmi: add CONFIG_NET dependency

Access to the socket API and the root network namespace is only available when networking is enabled:

ERROR: "kernel_sendmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_release" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_create_kern" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_getsockname" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "init_net" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_recvmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!

Adding a dependency on CONFIG_NET lets us build it in all randconfig builds.

Fixes 9b8a11e82615 ("soc: qcom: Introduce QMI encoder/decoder")
---
 drivers/remoteproc/Kconfig | 1 +
 drivers/soc/qcom/Kconfig   | 2 +-
 samples/Kconfig            | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)
drivers/remoteproc/Kconfig +1 -0
index a3658aa01838..027274008b08 100644
@@ -121,6 +121,7 @@ config QCOM_SYSMON
 	tristate "Qualcomm sysmon driver"
 	depends on RPMSG
 	depends on ARCH_QCOM
+	depends on NET
 	select QCOM_QMI_HELPERS
 	help
 	  The sysmon driver implements a sysmon QMI client and a handler for
drivers/soc/qcom/Kconfig +1 -1
index e050eb83341d..506763d81766 100644
@@ -37,7 +37,7 @@ config QCOM_PM
 
 config QCOM_QMI_HELPERS
 	tristate
-	depends on ARCH_QCOM
+	depends on ARCH_QCOM && NET
 	help
 	  Helper library for handling QMI encoded messages.  QMI encoded
 	  messages are used in communication between the majority of QRTR
samples/Kconfig +1 -0
index 4cb8af2f810f..168291de0184 100644
@@ -66,6 +66,7 @@ config SAMPLE_QMI_CLIENT
 	tristate "Build qmi client sample -- loadable modules only"
 	depends on m
 	depends on ARCH_QCOM
+	depends on NET
 	select QCOM_QMI_HELPERS
 	help
 	  Build an QMI client sample driver, which demonstrates how to
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 13 lines · Arnd Bergmann

Access to the socket API and the root network namespace is only available when networking is enabled:

ERROR: "kernel_sendmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_release" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "sock_create_kern" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_getsockname" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "init_net" [drivers/soc/qcom/qmi_helpers.ko] undefined!
ERROR: "kernel_recvmsg" [drivers/soc/qcom/qmi_helpers.ko] undefined!

Adding a dependency on CONFIG_NET lets us build it in all randconfig builds.

Quoted 7 lines
Fixes 9b8a11e82615 ("soc: qcom: Introduce QMI encoder/decoder")
---
 drivers/remoteproc/Kconfig | 1 +
 drivers/soc/qcom/Kconfig   | 2 +-
 samples/Kconfig            | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)