Skip to contentSkip to conversation

drm_hwcomposer: Fix comment on worker_test

PATCH In review Rhys Kidd 2 participants 2 messages Feb 26, 2018 – Feb 28, 2018

lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH 1/1 drm_hwcomposer: Fix comment on worker_test

Reflect the boolean logic of the accompanying code, which is run after Worker.InitWorker() has completed in test setup.

Change-Id If5187bdaa944c5d74a70c55b5b5e58e1baa20511
---
 tests/worker_test.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/worker_test.cpp +1 -1
index 38f91db..82523f0 100644
@@ -66,7 +66,7 @@ struct WorkerTest : public testing::Test {
 };
 
 TEST_F(WorkerTest, test_worker) {
-  // already isInitialized so should fail
+  // already isInitialized so should succeed
   ASSERT_TRUE(worker.initialized());
 
   int val = worker.value;
Signature · 6 lines
2.14.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
#1 lore raw

Thanks Rhys! Pushed.

I removed the Change-Id field though.

Rob.

Quoted 15 lines · Rhys Kidd

Reflect the boolean logic of the accompanying code, which is run after Worker.InitWorker() has completed in test setup.

Change-Id If5187bdaa944c5d74a70c55b5b5e58e1baa20511
---
  tests/worker_test.cpp | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/worker_test.cpp +0 -0
index 38f91db..82523f0 100644

tests/worker_test.cpp struct WorkerTest : public testing::Test { · line 72

Quoted 8 lines
tests/worker_test.cpp +1 -1
@@ -66,7 +66,7 @@ struct WorkerTest : public testing::Test {
  };
 
  TEST_F(WorkerTest, test_worker) {
-  // already isInitialized so should fail
+  // already isInitialized so should succeed
    ASSERT_TRUE(worker.initialized());
 
    int val = worker.value;

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel