Skip to contentSkip to conversation

icecc.bbclass: Ignore more icecream vars in hashes

PATCH Superseded Joshua Watt 2 participants 11 messages Feb 26, 2018 – Feb 27, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 icecc.bbclass: Ignore more icecream vars in hashes

Changing ICECC_ENV_VERSION or ICECC_SCHEDULER_HOST should not cause recipes to rebuild

---
 meta/classes/icecc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/icecc.bbclass +1 -1
index 36dcfbe6048..6e35e3be486 100644
@@ -30,7 +30,7 @@
 
 BB_HASHBASE_WHITELIST += "ICECC_PARALLEL_MAKE ICECC_DISABLED ICECC_USER_PACKAGE_BL \
     ICECC_USER_CLASS_BL ICECC_USER_PACKAGE_WL ICECC_PATH ICECC_ENV_EXEC \
-    ICECC_CARET_WORKAROUND ICECC_CFLAGS"
+    ICECC_CARET_WORKAROUND ICECC_CFLAGS ICECC_ENV_VERSION ICECC_SCHEDULER_HOST"
 
 ICECC_ENV_EXEC ?= "${STAGING_BINDIR_NATIVE}/icecc-create-env"
 
Signature · 1 line
2.14.3
#1 lore raw

PATCH 2/2 Ignore icecc-create-env in task signature

Changes to the icecc-create-env recipe should not cause all recipes to rebuild just because the have inherited icecc.

---
 meta/lib/oe/sstatesig.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/sstatesig.py +1 -1
index 3a8778eae01..6be9d32133a 100644
@@ -29,7 +29,7 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache):
         return True
 
     # Quilt (patch application) changing isn't likely to affect anything
-    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native']
+    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native', 'icecc-create-env-native']
     if depname in excludelist and recipename != depname:
         return False
 
Signature · 1 line
2.14.3
#2 lore raw

✗ patchtest: failure for "icecc.bbclass: Ignore more ice..." and 1 more

In reply to Joshua Watt

== Series Details ==

Series: "icecc.bbclass: Ignore more ice..." and 1 more
Revision: 1
URL : https://patchwork.openembedded.org/series/11106/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [2/2] Ignore icecc-create-env in task signature
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#3 lore raw

PATCH v2 1/2 icecc.bbclass: Ignore more icecream vars in hashes

In reply to Joshua Watt

Changing ICECC_ENV_VERSION or ICECC_SCHEDULER_HOST should not cause recipes to rebuild

---
 meta/classes/icecc.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/icecc.bbclass +1 -1
index 36dcfbe6048..6e35e3be486 100644
@@ -30,7 +30,7 @@
 
 BB_HASHBASE_WHITELIST += "ICECC_PARALLEL_MAKE ICECC_DISABLED ICECC_USER_PACKAGE_BL \
     ICECC_USER_CLASS_BL ICECC_USER_PACKAGE_WL ICECC_PATH ICECC_ENV_EXEC \
-    ICECC_CARET_WORKAROUND ICECC_CFLAGS"
+    ICECC_CARET_WORKAROUND ICECC_CFLAGS ICECC_ENV_VERSION ICECC_SCHEDULER_HOST"
 
 ICECC_ENV_EXEC ?= "${STAGING_BINDIR_NATIVE}/icecc-create-env"
 
Signature · 1 line
2.14.3
#4 lore raw

PATCH v2 2/2 sstatesig: Ignore icecc-create-env in task sigs

Changes to the icecc-create-env recipe should not cause all recipes to rebuild just because the have inherited icecc.

---
 meta/lib/oe/sstatesig.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/sstatesig.py +1 -1
index 3a8778eae01..6be9d32133a 100644
@@ -29,7 +29,7 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache):
         return True
 
     # Quilt (patch application) changing isn't likely to affect anything
-    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native']
+    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native', 'icecc-create-env-native']
     if depname in excludelist and recipename != depname:
         return False
 
Signature · 1 line
2.14.3
#5 lore raw

✗ patchtest: failure for "icecc.bbclass: Ignore more ice..." and 1 more (rev2)

In reply to Joshua Watt

== Series Details ==

Series: "icecc.bbclass: Ignore more ice..." and 1 more (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/11106/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [2/2] Ignore icecc-create-env in task signature
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#6 lore raw

✗ patchtest: failure for "icecc.bbclass: Ignore more ice..." and 1 more (rev3)

In reply to Joshua Watt

== Series Details ==

Series: "icecc.bbclass: Ignore more ice..." and 1 more (rev3)
Revision: 3
URL : https://patchwork.openembedded.org/series/11106/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at b30153a157)

* Patch            [2/2] Ignore icecc-create-env in task signature
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#7 lore raw

PATCH v3 1/2 icecc.bbclass: Ignore more icecream vars in hashes

In reply to Joshua Watt

Changing ICECC_ENV_VERSION or select variables that the user can set to control the behavior of icecc should not cause recipes to rebuild

---
 meta/classes/icecc.bbclass | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
meta/classes/icecc.bbclass +4 -1
index 36dcfbe6048..cab64f52703 100644
@@ -30,7 +30,10 @@
 
 BB_HASHBASE_WHITELIST += "ICECC_PARALLEL_MAKE ICECC_DISABLED ICECC_USER_PACKAGE_BL \
     ICECC_USER_CLASS_BL ICECC_USER_PACKAGE_WL ICECC_PATH ICECC_ENV_EXEC \
-    ICECC_CARET_WORKAROUND ICECC_CFLAGS"
+    ICECC_CARET_WORKAROUND ICECC_CFLAGS ICECC_ENV_VERSION \
+    ICECC_DEBUG ICECC_LOGFILE ICECC_REPEAT_RATE ICECC_PREFERRED_HOST \
+    ICECC_CLANG_REMOTE_CPP ICECC_IGNORE_UNVERIFIED ICECC_TEST_SOCKET \
+    "
 
 ICECC_ENV_EXEC ?= "${STAGING_BINDIR_NATIVE}/icecc-create-env"
 
Signature · 1 line
2.14.3
#8 lore raw

PATCH v3 2/2 sstatesig: Ignore icecc-create-env in task sigs

Changes to the icecc-create-env recipe should not cause all recipes to rebuild just because the have inherited icecc.

---
 meta/lib/oe/sstatesig.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/lib/oe/sstatesig.py +1 -1
index 3a8778eae01..6be9d32133a 100644
@@ -29,7 +29,7 @@ def sstate_rundepfilter(siggen, fn, recipename, task, dep, depname, dataCache):
         return True
 
     # Quilt (patch application) changing isn't likely to affect anything
-    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native']
+    excludelist = ['quilt-native', 'subversion-native', 'git-native', 'ccache-native', 'icecc-create-env-native']
     if depname in excludelist and recipename != depname:
         return False
 
Signature · 1 line
2.14.3
#9 lore raw

✗ patchtest: failure for "icecc.bbclass: Ignore more ice..." and 1 more (rev4)

In reply to Joshua Watt

== Series Details ==

Series: "icecc.bbclass: Ignore more ice..." and 1 more (rev4)
Revision: 4
URL : https://patchwork.openembedded.org/series/11106/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Patch            [2/2] Ignore icecc-create-env in task signature
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
#10 lore raw

✗ patchtest: failure for "icecc.bbclass: Ignore more ice..." and 1 more (rev5)

In reply to Joshua Watt

== Series Details ==

Series: "icecc.bbclass: Ignore more ice..." and 1 more (rev5)
Revision: 5
URL : https://patchwork.openembedded.org/series/11106/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at b30153a157)

* Patch            [2/2] Ignore icecc-create-env in task signature
 Issue             Shortlog does not follow expected format [test_shortlog_format] 
  Suggested fix    Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe