staging: rtl8723bs: use kmemdup for allocation and copy
PATCH 1/1 staging: rtl8723bs: use kmemdup for allocation and copy
Use kmemdup instead of kzalloc and memcpy to simplify the code. Issue found with coccicheck.
Signed-off-by Dafna Hirschfeld <[email protected]>
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +1 -2
@@ -433,13 +433,12 @@ s32 rtl8723b_FirmwareDownload(struct adapter *padapter, bool bUsedWoWLANFw) goto exit; } - pFirmware->szFwBuffer =kzalloc (fw->size,GFP_KERNEL ); + pFirmware->szFwBuffer =kmemdup (fw->data, fw->size,GFP_KERNEL );if (!pFirmware->szFwBuffer) { rtStatus = _FAIL; goto exit; } -memcpy (pFirmware->szFwBuffer, fw->data, fw->size); pFirmware->ulFwLength = fw->size;release_firmware (fw);if (pFirmware->ulFwLength >FW_8723B_SIZE ) {
Signature · 1 line
2.7.4