Skip to contentSkip to conversation

Add a warning that we do not officially support LibreSSL

PATCH In review Steffan Karger 4 participants 6 messages Feb 28, 2018 – Jan 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add a warning that we do not officially support LibreSSL

As discussed in the community meeting of 13-12-2017, we should warn our users that LibreSSL is not officially supported. We expect that it currently works, but it might suddenly break or we might decide to no longer build against LibreSSL in the future.

There seem to be ongoing efforts to make LibreSSL compatible with the OpenSSL 1.1 API. If they truly do that, it might also keep working.

For now, make sure people understand we do not really support LibreSSL.

---
 src/openvpn/options.c | 5 +++++
 1 file changed, 5 insertions(+)
src/openvpn/options.c +5 -0
index 41a42cf2..36d67b0f 100644
@@ -2949,6 +2949,11 @@ options_postprocess_mutate_invariant(struct options *options)
 static void
 options_postprocess_verify(const struct options *o)
 {
+#ifdef LIBRESSL_VERSION_NUMBER
+    msg(M_WARN, "WARNING: This OpenVPN was built against LibreSSL. "
+        "This might work, but is *not* supported and can break at any time.")
+#endif
+
     if (o->connection_list)
     {
         int i;
Signature · 1 line
2.14.1
#1 lore raw

[resending because the list rejected my mail from yesterday...]

src/openvpn/options.c options_postprocess_mutate_invariant(struct options *options) · line 2954

Quoted 2 lines · Steffan Karger
src/openvpn/options.c +2 -0
+    msg(M_WARN, "WARNING: This OpenVPN was built against LibreSSL. "
+        "This might work, but is *not* supported and can break at any time.")

Gah, this of course needs a ; at the end of the line - forgot to amend the commit before git send-email...

-Steffan

#2 lore raw
In reply to Steffan Karger

Hi,

Quoted 4 lines · Steffan Karger

As discussed in the community meeting of 13-12-2017, we should warn our users that LibreSSL is not officially supported. We expect that it currently works, but it might suddenly break or we might decide to no longer build against LibreSSL in the future.

Generally speaking, I agree.

Should we also add a warning (+ sleep 60 to be extra-annoying?) to configure if LibreSSL is detected?

gert

Signature · 3 lines
now what should I write here...

Gert Doering - Munich, Germany                             [email protected]...
#3 lore raw

Hi,

Quoted 10 lines · Gert Doering
Quoted 4 lines · Steffan Karger

As discussed in the community meeting of 13-12-2017, we should warn our users that LibreSSL is not officially supported. We expect that it currently works, but it might suddenly break or we might decide to no longer build against LibreSSL in the future.

Generally speaking, I agree.

Should we also add a warning (+ sleep 60 to be extra-annoying?) to configure if LibreSSL is detected?

I considered that (modulo the sleep 60) and wrote the code to do the configure check, but then thought that a not-suppressible warning in the logs would be sufficient. I still think it is, but don't mind re-adding it to configure.ac if you prefer that.

-Steffan

#4 lore raw
Quoted 11 lines · Steffan Karger

Hi,

Quoted 8 lines · Gert Doering
Quoted 4 lines · Steffan Karger

As discussed in the community meeting of 13-12-2017, we should warn our users that LibreSSL is not officially supported. We expect that it currently works, but it might suddenly break or we might decide to no longer build against LibreSSL in the future.

Generally speaking, I agree.

Quoted 7 lines
Quoted 2 lines

Should we also add a warning (+ sleep 60 to be extra-annoying?) to configure if LibreSSL is detected?

I considered that (modulo the sleep 60) and wrote the code to do the configure check, but then thought that a not-suppressible warning in the logs would be sufficient. I still think it is, but don't mind re-adding it to configure.ac if you prefer that.

As an OpenBSD developer and the maintainer of our OpenVPN port, I certainly care about building and using OpenVPN with LibreSSL. I have already provided patches in the past, and yesterday I pushed compat glue in LibreSSL so that openvpn-2.4.5 can build on OpenBSD (-current).

So I'm wondering what would be needed to consider LibreSSL "supported".

I hear that there are concerns over LibreSSL not being API-compatible with OpenSSL. As you may have noticed, LibreSSL recently introduced lots of OpenSSL-1.1+ interfaces. While there is no plan to support the full OpenSSL-1.1 API (tons of functions were added, not all of them seem useful...), the intent is to provide what the ecosystem actually needs. I can probably serve as a bridge between the two projects here.

If you see other points where I - or anyone else - can help, please share. :)

Signature · 1 line
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE
#5 lore raw
Quoted 21 lines
Quoted 5 lines

I considered that (modulo the sleep 60) and wrote the code to do the configure check, but then thought that a not-suppressible warning in the logs would be sufficient. I still think it is, but don't mind re-adding it to configure.ac if you prefer that.

As an OpenBSD developer and the maintainer of our OpenVPN port, I certainly care about building and using OpenVPN with LibreSSL. I have already provided patches in the past, and yesterday I pushed compat glue in LibreSSL so that openvpn-2.4.5 can build on OpenBSD (-current).

So I'm wondering what would be needed to consider LibreSSL "supported".

I hear that there are concerns over LibreSSL not being API-compatible with OpenSSL. As you may have noticed, LibreSSL recently introduced lots of OpenSSL-1.1+ interfaces. While there is no plan to support the full OpenSSL-1.1 API (tons of functions were added, not all of them seem useful...), the intent is to provide what the ecosystem actually needs. I can probably serve as a bridge between the two projects here.

Quoted 3 lines

If you see other points where I - or anyone else - can help, please share. :)

With my recent commits that use more OpenSSL 1.1.1 features building with LibreSSL breaks again since it claims to be OpenSSL 2.0 or something ridiculous like that. In my book claiming to support APIs you don't even know is a bad move.

With the current situation I would also ACK this patch. I see no good way at the moment for supporting LibreSSL.

Arne