Skip to contentSkip to conversation

ASoC: atmel: Remove redundant dev_err() call in probe function

PATCH In review Ladislav Michl 2 participants 2 messages Mar 1, 2018

Subsystems (4)
Sound ASoC Arm/Microchip (AT91) SoC support Microchip audio ASoC drivers
lore
Share & tools
lore

Ladislav Michl

author
#0 lore raw

PATCH v2 1/1 ASoC: atmel: Remove redundant dev_err() call in probe function

There is an error message within devm_ioremap_resource already, so remove the redundant dev_err() call.

Signed-off-by Ladislav Michl <[email protected]>
Acked-by Nicolas Ferre <[email protected]>

---
Changes:
- v2: None, just added Ack.

 sound/soc/atmel/atmel-classd.c | 7 ++-----
 sound/soc/atmel/atmel-pdmic.c  | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)
sound/soc/atmel/atmel-classd.c +2 -5
index 9baaf6bc5fbd..3d70061901a0 100644
@@ -583,11 +583,8 @@ static int atmel_classd_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	io_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(io_base)) {
-		ret =  PTR_ERR(io_base);
-		dev_err(dev, "failed to remap register memory: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(io_base))
+		return PTR_ERR(io_base);
 
 	dd->phy_base = res->start;
 	dd->dev = dev;
sound/soc/atmel/atmel-pdmic.c +2 -5
index 94f852574a44..915c2b064de1 100644
@@ -633,11 +633,8 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	io_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(io_base)) {
-		ret = PTR_ERR(io_base);
-		dev_err(dev, "failed to remap register memory: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(io_base))
+		return PTR_ERR(io_base);
 
 	dd->phy_base = res->start;
Signature · 1 line
2.16.2
Acked-by on v2 1/1
#1 lore raw
Quoted 5 lines · Ladislav Michl

There is an error message within devm_ioremap_resource already, so remove the redundant dev_err() call.

Signed-off-by Ladislav Michl <[email protected]>
Acked-by Nicolas Ferre <[email protected]>
Acked-by Alexandre Belloni <[email protected]>
Quoted 47 lines

---
Changes:
- v2: None, just added Ack.

 sound/soc/atmel/atmel-classd.c | 7 ++-----
 sound/soc/atmel/atmel-pdmic.c  | 7 ++-----
 2 files changed, 4 insertions(+), 10 deletions(-)
sound/soc/atmel/atmel-classd.c +2 -5
index 9baaf6bc5fbd..3d70061901a0 100644
@@ -583,11 +583,8 @@ static int atmel_classd_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	io_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(io_base)) {
-		ret =  PTR_ERR(io_base);
-		dev_err(dev, "failed to remap register memory: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(io_base))
+		return PTR_ERR(io_base);
 
 	dd->phy_base = res->start;
 	dd->dev = dev;
sound/soc/atmel/atmel-pdmic.c +2 -5
index 94f852574a44..915c2b064de1 100644
@@ -633,11 +633,8 @@ static int atmel_pdmic_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	io_base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(io_base)) {
-		ret = PTR_ERR(io_base);
-		dev_err(dev, "failed to remap register memory: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(io_base))
+		return PTR_ERR(io_base);
 
 	dd->phy_base = res->start;
Signature · 1 line
2.16.2
Signature · 3 lines
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com