Skip to contentSkip to conversation

arm: dts: omap3: Add missing #sound-dai-cells

PATCH New Rob Herring 2 participants 5 messages Mar 1, 2018 – Mar 5, 2018 Device tree bindings

lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 arm: dts: omap3: Add missing #sound-dai-cells

dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap3.dtsi +1 -0
index a005802cd52b..4043ecb38016 100644
@@ -557,6 +557,7 @@
 			dma-names = "tx", "rx";
 			clocks = <&mcbsp4_fck>;
 			clock-names = "fck";
+			#sound-dai-cells = <0>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 arm: dts: omap3: Add missing #sound-dai-cells

Quoted 7 lines · Rob Herring

dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Is this needed for the current -rc or is v4.17 OK?

Somehow I'm not seeing these with current -rc or next, is there some special option (not W=2 :) that you're using?

Regards,

Tony

Quoted 23 lines
Cc "Beno?t Cousson" <[email protected]>
Cc Tony Lindgren <[email protected]>
Cc linux-omap at vger.kernel.org
---
 arch/arm/boot/dts/omap3.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/omap3.dtsi +1 -0
index a005802cd52b..4043ecb38016 100644
@@ -557,6 +557,7 @@
 			dma-names = "tx", "rx";
 			clocks = <&mcbsp4_fck>;
 			clock-names = "fck";
+			#sound-dai-cells = <0>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.14.1
author maintainer
#2 lore raw

PATCH 1/1 arm: dts: omap3: Add missing #sound-dai-cells

Quoted 10 lines · Tony Lindgren
Quoted 7 lines · Rob Herring

dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Is this needed for the current -rc or is v4.17 OK?

4.17 is fine.

Quoted 2 lines

Somehow I'm not seeing these with current -rc or next, is there some special option (not W=2 :) that you're using?

Upstream dtc which I'm working on syncing to for 4.17.

Rob

#3 lore raw

PATCH 1/1 arm: dts: omap3: Add missing #sound-dai-cells

Quoted 10 lines · Rob Herring
Quoted 9 lines · Tony Lindgren
Quoted 7 lines · Rob Herring

dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Quoted 8 lines
Quoted 1 line

Is this needed for the current -rc or is v4.17 OK?

4.17 is fine.

Quoted 2 lines

Somehow I'm not seeing these with current -rc or next, is there some special option (not W=2 :) that you're using?

Upstream dtc which I'm working on syncing to for 4.17.

OK let me know if you want to queue along with your other changes and I'll ack or else I'll apply it up tomorrow.

Regards,

Tony

author maintainer
#4 lore raw

PATCH 1/1 arm: dts: omap3: Add missing #sound-dai-cells

Quoted 15 lines · Tony Lindgren
Quoted 14 lines · Rob Herring
Quoted 10 lines · Tony Lindgren
Quoted 7 lines · Rob Herring

dtc now gives the following warnings:

arch/arm/boot/dts/omap3-gta04a3.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a4.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0]) arch/arm/boot/dts/omap3-gta04a5.dtb: Warning (sound_dai_property): /sound_telephony/simple-audio-card,cpu: Missing property '#sound-dai-cells' in node /ocp at 68000000/mcbsp at 49026000 or bad phandle (referred from sound-dai[0])

Add the missing #sound-dai-cells property.

Is this needed for the current -rc or is v4.17 OK?

4.17 is fine.

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Somehow I'm not seeing these with current -rc or next, is there some special option (not W=2 :) that you're using?

Upstream dtc which I'm working on syncing to for 4.17.

OK let me know if you want to queue along with your other changes and I'll ack or else I'll apply it up tomorrow.

Please apply it.

Rob