bug: Use %pB in BUG and stack protector failure

PATCH RESEND Applied Kees Cook 1 participant 1 message Mar 1, 2018 Library code

lore

Share & tools

lore

Kees Cook

author

2018-03-01 22:57 UTC #0 lore raw

PATCH RESEND 1/1 bug: Use %pB in BUG and stack protector failure

The BUG and stack protector reports were still using a raw %p. This changes it to %pB for more meaningful output.

Fixes ad67b74d2469 ("printk: hash addresses printed with %p")

Cc [email protected]

Signed-off-by Kees Cook <[email protected]>

---
Resending through akpm as this isn't x86-specific ...

---
 kernel/panic.c | 2 +-
 lib/bug.c      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

kernel/panic.c +1 -1

index 2cfef408fec9..4b794f1d8561 100644
@@ -640,7 +640,7 @@ device_initcall(register_warn_debugfs);
  */
 __visible void __stack_chk_fail(void)
 {
-	panic("stack-protector: Kernel stack is corrupted in: %p\n",
+	panic("stack-protector: Kernel stack is corrupted in: %pB\n",
 		__builtin_return_address(0));
 }
 EXPORT_SYMBOL(__stack_chk_fail);

lib/bug.c +1 -1

index 551e4d405307..1077366f496b 100644
@@ -193,7 +193,7 @@ enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
 	if (file)
 		pr_crit("kernel BUG at %s:%u!\n", file, line);
 	else
-		pr_crit("Kernel BUG at %p [verbose debug info unavailable]\n",
+		pr_crit("Kernel BUG at %pB [verbose debug info unavailable]\n",
 			(void *)bugaddr);
 
 	return BUG_TRAP_TYPE_BUG;

Signature · 6 lines

2.7.4


-- 
Kees Cook
Pixel Security