staging: vt6655: Fix style violation for line ending in '('

PATCH Superseded Rinkle Jain 2 participants 2 messages Mar 3, 2018 Staging

lore

Share & tools

lore

Rinkle Jain

author

2018-03-03 15:23 UTC #0 lore raw

PATCH 1/1 staging: vt6655: Fix style violation for line ending in '('

Replace line ending with '(' with function parameters to resolve style issue found by checkpath.

Signed-off-by Rinkle Jain <[email protected]>

---
 drivers/staging/vt6655/baseband.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

drivers/staging/vt6655/baseband.h +4 -5

index b8ee33dcb352..432b348c81e1 100644
@@ -47,11 +47,10 @@
 #define TOP_RATE_1M         0x00100000
 
 unsigned int
-BBuGetFrameTime(
-	unsigned char byPreambleType,
-	unsigned char byPktType,
-	unsigned int cbFrameLength,
-	unsigned short wRate
+BBuGetFrameTime(unsigned char byPreambleType,
+		unsigned char byPktType,
+		unsigned int cbFrameLength,
+		unsigned short wRate
 );
 
 void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,

Signature · 1 line

2.14.3

Julia Lawall

2018-03-03 15:26 UTC #1 lore raw

Quoted 16 lines · Rinkle Jain

Replace line ending with '(' with function parameters to resolve style issue found by checkpath.
Signed-off-by Rinkle Jain <[email protected]>
---
 drivers/staging/vt6655/baseband.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
drivers/staging/vt6655/baseband.h +0 -0
index b8ee33dcb352..432b348c81e1 100644
@@ -47,11 +47,10 @@
 #define TOP_RATE_1M         0x00100000
 
 unsigned int

drivers/staging/vt6655/baseband.h line 54

Quoted 10 lines

drivers/staging/vt6655/baseband.h +4 -5

-BBuGetFrameTime(
-	unsigned char byPreambleType,
-	unsigned char byPktType,
-	unsigned int cbFrameLength,
-	unsigned short wRate
+BBuGetFrameTime(unsigned char byPreambleType,
+		unsigned char byPktType,
+		unsigned int cbFrameLength,
+		unsigned short wRate
 );

I think that the code could still be improved, to use more of the horizontal space and not leave the ); on a line by itself. Look around in the kernel outside staging at .h files to see how other function prototype declarations look.

julia

Quoted 12 lines

drivers/staging/vt6655/baseband.h +0 -1
 void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
--
2.14.3
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303152244.GA9913%40tic-tac.
For more options, visit https://groups.google.com/d/optout.