+ mm-relax-ptrace-mode-in-process_vm_readv2.patch added to -mm tree
A message that is not in the archive (sent off-list or not yet received): 20180306000721.gx9qqFGe8%[email protected]
A message that is not in the archive (sent off-list or not yet received): CAGXu5jKP03X7+XX9Oq+vVjQJhO1+A9ZyLDD+Gsxv2nRCgVD4wQ@mail.gmail.com
Quoted 7 lines · Kees Cook
Quoted 3 lines · On Mon, Mar 5, 2018 at 4:07 PM, <[email protected]> wrote:
It is more natural to check for read-from-memory permissions in case of
process_vm_readv()asPTRACE_MODE_ATTACHis equivalent to write permissions.NAK, this weakens the existing permission model for reading
What if existing permission model is overezealous?
/proc/*/auxv, /proc/*/environ, /proc*/cmdline, /proc/*/mem opened for reading and process_vm_readv(2) should do PTRACE_MODE_READ and everything else should do PTRACE_MODE_ATTACH.
Quoted 9 lines
cross-process memory. ptrace-readable memory can only be done with ATTACH, and
/proc/$pid/memalso requires ATTACH:static int
mem_open(struct inode *inode, struct file *file){ int ret = __mem_open(inode, file, PTRACE_MODE_ATTACH);Only auxv and environ use READ. We should absolutely not create a pass to a lower permission requirement here.
Quoted 7 lines · Alexey Dobriyan
Quoted 6 lines · Kees Cook
Quoted 3 lines · On Mon, Mar 5, 2018 at 4:07 PM, <[email protected]> wrote:
It is more natural to check for read-from-memory permissions in case of
process_vm_readv()asPTRACE_MODE_ATTACHis equivalent to write permissions.
Quoted 7 lines
Quoted 1 line
NAK, this weakens the existing permission model for reading
What if existing permission model is overezealous?
/proc/*/auxv,/proc/*/environ, /proc*/cmdline,/proc/*/memopened for reading andprocess_vm_readv(2)should doPTRACE_MODE_READand everything else should doPTRACE_MODE_ATTACH.
Or in other words:
what if there should be 3 levels:
1) permission to write to address space
2) permission to read arbitrarily from adress space
3) permission to read auxv, argv and envp
Current code conflates (1) and (2).
Quoted 16 lines · Alexey Dobriyan
Quoted 7 lines · Alexey Dobriyan
Quoted 6 lines · Kees Cook
Quoted 3 lines · On Mon, Mar 5, 2018 at 4:07 PM, <[email protected]> wrote:
It is more natural to check for read-from-memory permissions in case of
process_vm_readv()asPTRACE_MODE_ATTACHis equivalent to write permissions.Quoted 7 lines
Quoted 1 line
NAK, this weakens the existing permission model for reading
What if existing permission model is overezealous?
/proc/*/auxv,/proc/*/environ, /proc*/cmdline,/proc/*/memopened for reading andprocess_vm_readv(2)should doPTRACE_MODE_READand everything else should doPTRACE_MODE_ATTACH.
Quoted 8 lines
Or in other words:
what if there should be 3 levels:
1) permission to write to address space
2) permission to read arbitrarily from adress space
3) permission to read auxv, argv and envpCurrent code conflates (1) and (2).
There is also:
4) permission to read address layout (e.g. access to /proc/$pid/maps)
1 and 2 require ATTACH
3 and 4 require READ
ATTACH is a higher bar, and I think it is appropriate here, still, for 2, since being able to examine secrets in memory should be considered a security boundary.
Is there something you're trying from userspace that is being blocked?
-Kees
Signature · 2 lines
Kees Cook Pixel Security