Skip to contentSkip to conversation

net/ncsi: use kfree_skb() instead of kfree()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 8, 2018 – Mar 9, 2018

Subsystems (4)
Networking Network drivers Kernel janitors Ncsi library
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/2 net/ncsi: use kfree_skb() instead of kfree()

We're supposed to use kfree_skb() to free these sk_buffs.

Fixes 955dc68cb9b2 ("net/ncsi: Add generic netlink family")
Signed-off-by Dan Carpenter <[email protected]>
net/ncsi/ncsi-netlink.c +2 -2
index d4201665a580..b73239b76349 100644
@@ -183,7 +183,7 @@ static int ncsi_pkg_info_nl(struct sk_buff *msg, struct genl_info *info)
 	hdr = genlmsg_put(skb, info->snd_portid, info->snd_seq,
 			  &ncsi_genl_family, 0, NCSI_CMD_PKG_INFO);
 	if (!hdr) {
-		kfree(skb);
+		kfree_skb(skb);
 		return -EMSGSIZE;
 	}
 

@@ -204,7 +204,7 @@ static int ncsi_pkg_info_nl(struct sk_buff *msg, struct genl_info *info)
 
 err:
 	genlmsg_cancel(skb, hdr);
-	kfree(skb);
+	kfree_skb(skb);
 	return rc;
 }