Skip to contentSkip to conversation

Fix: do not use CONFIG_HOTPLUG_CPU for the new hotplug API

PATCH Mathieu Desnoyers 2 participants 3 messages Mar 12, 2018 – Mar 13, 2018 3 messages not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 9 lines · ----- On Mar 11, 2018, at 10:02 AM, Lars Persson [email protected] wrote:

Kernel configurations without CONFIG_HOTPLUG_CPU throw an unknown symbol error when attempting to insert the lttng-trace module:
lttng_tracer: Unknown symbol lttng_hp_prepare (err 0)
lttng_tracer: Unknown symbol lttng_hp_online (err 0)

This was caused by lttng-events and lttng-context-perf-counter not agreeing on which preprocessor condition that should guard the use of the hotplug API. In fact the API is available also on kernels built without CONFIG_HOTPLUG_API.

Do you mean CONFIG_HOTPLUG_CPU above ?

Thanks,

Mathieu

Quoted 28 lines

---
lttng-events.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
lttng-events.c +1 -1
index 6f122dd..2cd650f 100644
@@ -2644,7 +2644,7 @@ void lttng_transport_unregister(struct lttng_transport
 *transport)
 }
 EXPORT_SYMBOL_GPL(lttng_transport_unregister);
 
-#if (defined(CONFIG_HOTPLUG_CPU) && (LINUX_VERSION_CODE >=
 KERNEL_VERSION(4,10,0)))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0))
 

enum cpuhp_state lttng_hp_prepare;
enum cpuhp_state lttng_hp_online;
--
2.11.0

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 7 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
#3 lore raw
In reply to a message not in the archive
Quoted 7 lines · Mathieu Desnoyers
Quoted 5 lines · ----- On Mar 11, 2018, at 10:02 AM, Lars Persson [email protected] wrote:

Kernel configurations without CONFIG_HOTPLUG_CPU throw an unknown symbol error when attempting to insert the lttng-trace module:
lttng_tracer: Unknown symbol lttng_hp_prepare (err 0)
lttng_tracer: Unknown symbol lttng_hp_online (err 0)

Quoted 6 lines
Quoted 4 lines

This was caused by lttng-events and lttng-context-perf-counter not agreeing on which preprocessor condition that should guard the use of the hotplug API. In fact the API is available also on kernels built without CONFIG_HOTPLUG_API.

Do you mean CONFIG_HOTPLUG_CPU above ?

Yes, thanks for spotting the mistake. Feel free to edit my commit message.

- Lars

Quoted 29 lines

Thanks,

Mathieu

Quoted 24 lines

---
lttng-events.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
lttng-events.c +1 -1
index 6f122dd..2cd650f 100644
@@ -2644,7 +2644,7 @@ void lttng_transport_unregister(struct lttng_transport
 *transport)
 }
 EXPORT_SYMBOL_GPL(lttng_transport_unregister);
 
-#if (defined(CONFIG_HOTPLUG_CPU) && (LINUX_VERSION_CODE >=
 KERNEL_VERSION(4,10,0)))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0))
 

enum cpuhp_state lttng_hp_prepare;
enum cpuhp_state lttng_hp_online;
--
2.11.0

Quoted 5 lines
Quoted 4 lines

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

#5 lore raw
In reply to a message not in the archive
Quoted 8 lines · ----- On Mar 13, 2018, at 6:20 AM, Lars Persson [email protected] wrote:
Quoted 7 lines · Mathieu Desnoyers
Quoted 5 lines · ----- On Mar 11, 2018, at 10:02 AM, Lars Persson [email protected] wrote:

Kernel configurations without CONFIG_HOTPLUG_CPU throw an unknown symbol error when attempting to insert the lttng-trace module:
lttng_tracer: Unknown symbol lttng_hp_prepare (err 0)
lttng_tracer: Unknown symbol lttng_hp_online (err 0)

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines

This was caused by lttng-events and lttng-context-perf-counter not agreeing on which preprocessor condition that should guard the use of the hotplug API. In fact the API is available also on kernels built without CONFIG_HOTPLUG_API.

Do you mean CONFIG_HOTPLUG_CPU above ?

Yes, thanks for spotting the mistake. Feel free to edit my commit message.

Merged with this modification into master, 2.9, 2.10, thanks!

Mathieu

Quoted 36 lines

- Lars

Quoted 33 lines

Thanks,

Mathieu

Quoted 28 lines

---
lttng-events.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
lttng-events.c +1 -1
index 6f122dd..2cd650f 100644
@@ -2644,7 +2644,7 @@ void lttng_transport_unregister(struct lttng_transport
 *transport)
 }
 EXPORT_SYMBOL_GPL(lttng_transport_unregister);
 
-#if (defined(CONFIG_HOTPLUG_CPU) && (LINUX_VERSION_CODE >=
 KERNEL_VERSION(4,10,0)))
+#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,10,0))
 

enum cpuhp_state lttng_hp_prepare;
enum cpuhp_state lttng_hp_online;
--
2.11.0

_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Signature · 7 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev