Skip to contentSkip to conversation

USB: serial: option: reimplement interface masking

DISCUSSION Johan Hovold 1 participant 1 message Mar 12, 2018 USB

lore
Share & tools
lore
#0 lore raw
Quoted 17 lines · Greg Kroah-Hartman
Quoted 16 lines · Johan Hovold

Reimplement interface masking using device flags stored directly in the device-id table. This will make it easier to add and maintain device-id entries by using a more compact and readable notation compared to the current implementation (which manages pairs of masks in separate blacklist structs).

Two convenience macros are used to flag an interface as either reserved or as not supporting modem-control requests:

	{ USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
	  .driver_info = NCTRL(0) | RSVD(3) },

For now, we limit the highest maskable interface number to seven, which allows for (up to 16) additional device flags to be added later should need arise.

Quoted 6 lines
Quoted 4 lines

Note that this will likely need to be backported to stable in order to make future device-id backports more manageable.

Thanks for the review. Now applied for -next.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html