Detect early free of a live mm
Subsystems (3)
PATCH v2 1/1 Detect early free of a live mm
KASAN splats indicate that in some cases we free a live mm, then continue to access it, with potentially disastrous results. This is likely due to a mismatched mmdrop() somewhere in the kernel, but so far the culprit remains elusive.
Let's have __mmdrop() verify that the mm isn't live for the current task, similar to the existing check for init_mm. This way, we can catch this class of issue earlier, and without requiring KASAN.
Currently, idle_task_exit() leaves active_mm stale after it switches to init_mm. This isn't harmful, but will trigger the new assertions, so we must adjust idle_task_exit() to update active_mm.
--- kernel/fork.c | 2 ++ kernel/sched/core.c | 1 + 2 files changed, 3 insertions(+)
Since v1 [1]:
* Use WARN_ON_ONCE()
* Avoid spurious warning in idle_task_exit()
Mark.
[1] https://lkml.kernel.org/r/[email protected]
kernel/fork.c +2 -0
@@ -595,6 +595,8 @@ static void check_mm(struct mm_struct *mm)void __mmdrop (struct mm_struct *mm) {BUG_ON (mm == &init_mm); +WARN_ON_ONCE (mm == current->mm); +WARN_ON_ONCE (mm == current->active_mm);mm_free_pgd (mm);destroy_context (mm);hmm_mm_destroy (mm);
kernel/sched/core.c +1 -0
@@ -5506,6 +5506,7 @@ void idle_task_exit(void)if (mm != &init_mm) {switch_mm (mm, &init_mm, current); + current->active_mm = &init_mm;finish_arch_post_lock_switch (); }mmdrop (mm);
Signature · 1 line
2.11.0