ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)
PATCH v3 1/1 ppc440_pcix: Change some error_report to qemu_log_mask(LOG_UNIMP, ...)
Using log unimp is more appropriate for these messages and this also silences them by default so they won't clobber make check output when tests are added for this board.
---
v3: Include qemu/log.h to avoid undeclared function warning
v2: Use defined format string for printing hwaddr instead of casting. I guess this does not invalidate the R-b tag of v1 so I've added that too.
hw/ppc/ppc440_pcix.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)
hw/ppc/ppc440_pcix.c +7 -4
@@ -21,6 +21,7 @@#include "qemu/osdep.h" #include "qemu/error-report.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/ppc/ppc.h" #include "hw/ppc/ppc4xx.h"
@@ -286,8 +287,9 @@ static void ppc440_pcix_reg_write4(void *opaque, hwaddr addr,break ;default : -error_report ("%s: unhandled PCI internal register 0x%lx" , __func__, - (unsigned long )addr); +qemu_log_mask (LOG_UNIMP , +"%s: unhandled PCI internal register 0x%" HWADDR_PRIx"\n" , + __func__, addr);break ; } }
@@ -377,8 +379,9 @@ static uint64_t ppc440_pcix_reg_read4(void *opaque, hwaddr addr,break ;default : -error_report ("%s: invalid PCI internal register 0x%lx" , __func__, - (unsigned long )addr); +qemu_log_mask (LOG_UNIMP , +"%s: invalid PCI internal register 0x%" HWADDR_PRIx"\n" , + __func__, addr); val =0 ; }
Signature · 1 line
2.7.6
David Gibson
AppliedOn Tue, Mar 13, 2018 at 12:26:56PM +0100, BALATON Zoltan wrote:
1;5002;0c> Using log unimp is more appropriate for these messages and this also
Quoted 5 lines
silences them by default so they won't clobber make check output when tests are added for this board.
Signed-off-by BALATON Zoltan <[email protected]>Reviewed-by Thomas Huth <[email protected]>
Applied, thanks.
Quoted 44 lines
---
v3: Includeqemu/log.hto avoid undeclared function warning
v2: Use defined format string for printing hwaddr instead of casting. I guess this does not invalidate the R-b tag of v1 so I've added that too.hw/ppc/ppc440_pcix.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-)hw/ppc/ppc440_pcix.c +7
-4@@ -21,6 +21,7 @@#include "qemu/osdep.h" #include "qemu/error-report.h" +#include "qemu/log.h" #include "hw/hw.h" #include "hw/ppc/ppc.h" #include "hw/ppc/ppc4xx.h" @@ -286,8 +287,9 @@ static void ppc440_pcix_reg_write4(void *opaque, hwaddr addr,break ;default : -error_report ("%s: unhandled PCI internal register 0x%lx" , __func__, - (unsigned long )addr); +qemu_log_mask (LOG_UNIMP , +"%s: unhandled PCI internal register 0x%" HWADDR_PRIx"\n" , + __func__, addr);break ; } }@@ -377,8 +379,9 @@ static uint64_t ppc440_pcix_reg_read4(void *opaque, hwaddr addr,break ;default : -error_report ("%s: invalid PCI internal register 0x%lx" , __func__, - (unsigned long )addr); +qemu_log_mask (LOG_UNIMP , +"%s: invalid PCI internal register 0x%" HWADDR_PRIx"\n" , + __func__, addr); val =0 ; }
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson