Skip to contentSkip to conversation

HACK: enable the chamelium HDMI-CRC-multiple test

PATCH In review Maxime Ripard 3 participants 3 messages Mar 13, 2018 – Mar 14, 2018

lore
Share & tools
lore

Maxime Ripard

author
#0 lore raw

PATCH 1/1 HACK: enable the chamelium HDMI-CRC-multiple test

It seems like there's a regression (at least using the vc4 DRM display driver) when doing multiple calls to tests/kms_chamelium.c enable_output after a single prepare_output.

Indeed, the DRM atomic_state doesn't seem to be full on the second run, especially for the CRTC that doesn't have any encoder or connector enabled (and isn't set as active). This will later fail here:
https://elixir.bootlin.com/linux/v4.16-rc5/source/drivers/gpu/drm/drm_atomic_helper.c#L607

With the atomic_commit failing. This went unnoticed mostly because all the chamelium test cases that are enabled in the test suites do not follow that pattern.

Since there's nothing really driver specific and it all seems that the generic code in IGT is doing something wrong, let's try to run it on intel's GPU to confirm (or deny) that it's broken for everyone.

Signed-off-by Maxime Ripard <[email protected]>
---
 tests/intel-ci/fast-feedback.testlist | 1 +
 1 file changed, 1 insertion(+)
tests/intel-ci/fast-feedback.testlist +1 -0
index f71a16bcd191..847889d7220f 100644
@@ -204,6 +204,7 @@ igt@kms_chamelium@dp-crc-fast
 igt@kms_chamelium@hdmi-hpd-fast
 igt@kms_chamelium@hdmi-edid-read
 igt@kms_chamelium@hdmi-crc-fast
+igt@kms_chamelium@hdmi-crc-multiple
 igt@kms_chamelium@vga-hpd-fast
 igt@kms_chamelium@vga-edid-read
 igt@kms_chamelium@common-hpd-after-suspend
Signature · 6 lines
2.14.3

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI
#1 lore raw

✗ Fi.CI.BAT: warning for HACK: enable the chamelium HDMI-CRC-multiple test

== Series Details ==

== Series Details ==

Series: HACK: enable the chamelium HDMI-CRC-multiple test
URL : https://patchwork.freedesktop.org/series/39872/
State : warning

== Summary ==

IGT patchset tested on top of latest successful build 1bb3995eb6dba8e43981e0378e1c6eea3f730a0f tests/i915_query: fix expected subslice count on hsw

with latest DRM-Tip kernel build CI_DRM_3917
874b86a75985 drm-tip: 2018y-03m-13d-12h-36m-17s UTC integration manifest

No testlist changes.

---- Possible new issues:

Test kms_busy:

        Subgroup basic-flip-a:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-b:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-c:
                skip       -> PASS       (fi-ivb-3770)
Test kms_cursor_legacy:
        Subgroup basic-busy-flip-before-cursor-atomic:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-busy-flip-before-cursor-legacy:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-after-cursor-atomic:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-after-cursor-legacy:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-after-cursor-varying-size:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-before-cursor-atomic:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-before-cursor-legacy:
                skip       -> PASS       (fi-ivb-3770)
        Subgroup basic-flip-before-cursor-varying-size:
                skip       -> PASS       (fi-ivb-3770)
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (fi-ivb-3770)
Test kms_frontbuffer_tracking:
        Subgroup basic:
                skip       -> PASS       (fi-ivb-3770)

---- Known issues:

Test gem_mmap_gtt:

        Subgroup basic-small-bo-tiledx:
                fail       -> PASS       (fi-gdg-551) fdo#102575
Test kms_chamelium:
        Subgroup dp-crc-fast:
                fail       -> PASS       (fi-kbl-7500u) fdo#103841
Test prime_vgem:
        Subgroup basic-fence-flip:
                skip       -> PASS       (fi-ivb-3770) fdo#104008

fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:289  pass:267  dwarn:0   dfail:0   fail:0   skip:22  time:431s
fi-bdw-gvtdvm    total:289  pass:264  dwarn:0   dfail:0   fail:0   skip:25  time:435s
fi-blb-e6850     total:289  pass:223  dwarn:1   dfail:0   fail:0   skip:65  time:385s
fi-bsw-n3050     total:289  pass:242  dwarn:0   dfail:0   fail:0   skip:47  time:533s
fi-bwr-2160      total:289  pass:183  dwarn:0   dfail:0   fail:0   skip:106 time:298s
fi-bxt-dsi       total:289  pass:258  dwarn:0   dfail:0   fail:0   skip:31  time:512s
fi-bxt-j4205     total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:515s
fi-byt-j1900     total:289  pass:253  dwarn:0   dfail:0   fail:0   skip:36  time:512s
fi-byt-n2820     total:289  pass:249  dwarn:0   dfail:0   fail:0   skip:40  time:498s
fi-cfl-8700k     total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:410s
fi-cfl-s2        total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:585s
fi-cnl-y3        total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:593s
fi-elk-e7500     total:289  pass:229  dwarn:0   dfail:0   fail:0   skip:60  time:429s
fi-gdg-551       total:289  pass:180  dwarn:0   dfail:0   fail:0   skip:109 time:315s
fi-glk-1         total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:534s
fi-hsw-4770      total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:404s
fi-ilk-650       total:289  pass:228  dwarn:0   dfail:0   fail:0   skip:61  time:421s
fi-ivb-3520m     total:289  pass:259  dwarn:0   dfail:0   fail:0   skip:30  time:465s
fi-ivb-3770      total:289  pass:255  dwarn:0   dfail:0   fail:0   skip:34  time:434s
fi-kbl-7500u     total:289  pass:263  dwarn:1   dfail:0   fail:0   skip:25  time:476s
fi-kbl-7567u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:470s
fi-kbl-r         total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:515s
fi-pnv-d510      total:289  pass:222  dwarn:1   dfail:0   fail:0   skip:66  time:646s
fi-skl-6260u     total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-skl-6600u     total:289  pass:261  dwarn:0   dfail:0   fail:0   skip:28  time:533s
fi-skl-6700hq    total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:541s
fi-skl-6700k2    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:525s
fi-skl-6770hq    total:289  pass:268  dwarn:0   dfail:0   fail:0   skip:21  time:504s
fi-skl-guc       total:289  pass:260  dwarn:0   dfail:0   fail:0   skip:29  time:429s
fi-skl-gvtdvm    total:289  pass:265  dwarn:0   dfail:0   fail:0   skip:24  time:442s
fi-snb-2520m     total:289  pass:248  dwarn:0   dfail:0   fail:0   skip:41  time:539s
fi-snb-2600      total:289  pass:248  dwarn:0   dfail:0   fail:0   skip:41  time:413s
Blacklisted hosts:
fi-cfl-u         total:289  pass:262  dwarn:0   dfail:0   fail:0   skip:27  time:516s
fi-cnl-drrs      total:289  pass:257  dwarn:3   dfail:0   fail:0   skip:29  time:523s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1120/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx