Skip to contentSkip to conversation

ubifs: Reintroduce using CONFIG_UBIFS_SILENCE_MSG

PATCH Superseded Petr Vorel 1 participant 1 message Mar 18, 2018

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

PATCH 1/3 ubifs: Reintroduce using CONFIG_UBIFS_SILENCE_MSG

Hi,

Quoted 27 lines

Use of CONFIG_UBIFS_SILENCE_MSG was added in 147162dac6 ("ubi: ubifs: Turn off verbose prints")

Then it was removed in
ff94bc40af ("mtd, ubi, ubifs: resync with Linux-3.14")

Cc Joe Hershberger <[email protected]>
Cc Heiko Schocher <[email protected]>

---
Note, not sure whether we need to keep this workaround. If not, it might be better to get rid of both CONFIG_UBI_SILENCE_MSG and CONFIG_UBIFS_SILENCE_MSG.

Petr

---
 fs/ubifs/ubifs.h | 4 ++++
 1 file changed, 4 insertions(+)
fs/ubifs/ubifs.h +0 -0
index 1d89465205..b4ce706a8e 100644
@@ -618,9 +618,13 @@ static inline ino_t parent_ino(struct dentry *dentry)
 #define UBIFS_VERSION 1
 
 /* Normal UBIFS messages */

fs/ubifs/ubifs.h static inline ino_t parent_ino(struct dentry *dentry) · line 630

Quoted 10 lines
fs/ubifs/ubifs.h +4 -0
+#ifdef CONFIG_UBIFS_SILENCE_MSG
+#define ubifs_msg(c, fmt, ...)
+#else
 #define ubifs_msg(c, fmt, ...)                                      \
        pr_notice("UBIFS (ubi%d:%d): " fmt "\n",                    \
                  (c)->vi.ubi_num, (c)->vi.vol_id, ##__VA_ARGS__)
+#endif
 /* UBIFS error messages */
 #ifndef __UBOOT__
 #define ubifs_err(c, fmt, ...)

ping, please.

Kind regards,
Petr